DOCSP-31089: Improve bulk operation examples #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mongoKart
approved these changes
Sep 12, 2023
Comment on lines
218
to
219
| a second parameter to specify the execution of the bulk operations as | ||
| ordered or unordered. |
There was a problem hiding this comment.
S:
Suggested change
| a second parameter to specify the execution of the bulk operations as | |
| ordered or unordered. | |
| a second parameter to specify whether the execution of the bulk operations is | |
| ordered or unordered. |
Comment on lines
233
to
239
| - An insert operation for a document where the ``name`` is ``"Zaynab Omar"`` and the | ||
| ``age`` is ``37`` | ||
| - A replace operation for a document where the ``_id`` is ``1`` with a new document | ||
| that contains the ``location`` field | ||
| - An update operation for a document where the ``name`` is ``"Zaynab Omar"`` to change the ``name`` | ||
| field to ``"Zaynab Hassan"`` | ||
| - A delete operation for all documents that have an ``age`` value greater than ``50`` |
There was a problem hiding this comment.
S: suggestion for clarity/syntax (didn't include it here, but also a good idea to specify which document changing instead of just "a document"--e.g., "updates the first matching document...")
Suggested change
| - An insert operation for a document where the ``name`` is ``"Zaynab Omar"`` and the | |
| ``age`` is ``37`` | |
| - A replace operation for a document where the ``_id`` is ``1`` with a new document | |
| that contains the ``location`` field | |
| - An update operation for a document where the ``name`` is ``"Zaynab Omar"`` to change the ``name`` | |
| field to ``"Zaynab Hassan"`` | |
| - A delete operation for all documents that have an ``age`` value greater than ``50`` | |
| - An operation that inserts a document where the ``name`` is ``"Zaynab Omar"`` and the | |
| ``age`` is ``37`` | |
| - An operation that replaces the document where the ``_id`` is ``1`` with a new document | |
| that contains the ``location`` field | |
| - An operation that updates a document where the ``name`` is ``"Zaynab Omar"`` to change the ``name`` | |
| field to ``"Zaynab Hassan"`` | |
| - An operation that deletes all documents where the ``age`` value is greater than ``50`` |
Comment on lines
+123
to
+126
| bulkOperations.add(insertDoc); | ||
| bulkOperations.add(replaceDoc); | ||
| bulkOperations.add(updateDoc); | ||
| bulkOperations.add(deleteDoc); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-31089
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/java/docsworker-xlarge/DOCSP-31089-fix-bulk-examples/fundamentals/crud/write-operations/bulk/
Self-Review Checklist