DOCSP-31694: SOCKS5 proxy support #439
Conversation
ccho-mongodb
changed the title
| .. TODO | ||
| - provide the link for the proxysettings builder once the API docs are generated |
There was a problem hiding this comment.
This will be replaced by the ProxySettings Builder API docs link once v4.11 is published.
ccho-mongodb
changed the title
| .. code-block:: java | ||
| :emphasize-lines: 4-11 | ||
|
|
||
| MongoClient mongoClient = MongoClients.create( |
There was a problem hiding this comment.
It looks like this code snippet starts off indented more than it needs to be. Since the third line is pretty long can the extra indentation be removed to show as much as possible without scrolling?
ccho-mongodb
requested review from
a team and
vbabanin
and removed request for
a team
|
|
||
| * - **proxyUsername** | ||
| - String | ||
| - Specifies the username for authentication to the SOCKS5 proxy server. |
There was a problem hiding this comment.
it might be beneficial to mention that proxyUsername and proxyPassword should always be specified together, as the driver requires both or none.
There was a problem hiding this comment.
Currently, the Socks5 proxy feature specifically functions with the SocketStreamFactory, which acts as the default in the absence of a configured SocketStreamFactoryFactory. Including this detail in the documentation could be beneficial. Everything else, LGTM!
I wasn't able to find "SocketStreamFactoryFactory", so I assumed that you meant "StreamFactoryFactory" when adding the callout here. Let me know if this works! |
Yes, |
* DOCSP-32942: Deprecated Methods * review feedback * DOCSP-33241: fix extended JSON example id field (#447) * DOCSP-33241: fix extended JSON example id field * DOCSP-31694: SOCKS5 proxy support (#439) * DOCSP-31694: SOCKS5 proxy support * DOCSP-33300: Fix aggregation operator links to the manual (#448) * DOCSP-32300 Adds compatibility info to landing page (#449) * DOCSP-31907 Split Event (#457) * tech review feedback * format * CC feedback * CC feedback pt 2 * DOCSP-31907 - Add paragraph from server docs (#460) * DOCSP-32942: Deprecated Methods * review feedback * tech review feedback * format * CC feedback * CC feedback pt 2 * build
Pull Request Info
Note: This PR will require one edit to add the API docs link for the builder prior to merging for the upcoming v4.11 driver.
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-31694
Staging - https://preview-mongodbcchomongodb.gatsbyjs.io/java/DOCSP-31694-socks5-proxy/fundamentals/connection/socks/
Self-Review Checklist