Skip to content

DOCSP-33345: Java code comments pt. 1 #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 18, 2023

Conversation

norareidy
Copy link
Contributor

@norareidy norareidy commented Oct 9, 2023

Copy link
Collaborator

@caitlindavey caitlindavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments about the summary comments at the top of each file. Once those changes are made it can be approved. Thanks!

@@ -1,3 +1,9 @@
/**
* This file demonstrates MongoDB bulk write operations by using the Java driver.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personal opinion: There's something about the "This file" that feels clunky to me. I think maybe we delete that and change to:

Suggested change
* This file demonstrates MongoDB bulk write operations by using the Java driver.
* Conduct bulk write operations by using the Java driver.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And change comment to single line comment //

@@ -1,3 +1,9 @@
/**
* This file demonstrates MongoDB bulk write operations by using the Java driver.
* It connects to a MongoDB deployment, accesses the "sample_mflix" database,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think delete the next two rows.

@@ -1,3 +1,9 @@
/**
* This file demonstrates how to run a command by using the Java driver.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same note as above.

Suggested change
* This file demonstrates how to run a command by using the Java driver.
* // Run a command by using the MongoDB Java driver.

@@ -1,3 +1,10 @@
/**
* This file demonstrates how to perform count operations by using the Java driver.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* This file demonstrates how to perform count operations by using the Java driver.
* // Perform count operations by using the MongoDB Java driver.

@@ -1,3 +1,10 @@
/**
* This file demonstrates how to delete multiple documents in a collection by
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* This file demonstrates how to delete multiple documents in a collection by
* // Delete multiple documents in a collection using the MongoDB Java driver.

Comment on lines 2 to 6
* This file demonstrates how to delete a document in a collection by using the
* Java driver.
* The file connects to a MongoDB deployment, accesses the "sample_mflix" database,
* and deletes a document in the "movies" collection based on a specified query.
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* This file demonstrates how to delete a document in a collection by using the
* Java driver.
* The file connects to a MongoDB deployment, accesses the "sample_mflix" database,
* and deletes a document in the "movies" collection based on a specified query.
*/
* // Delete a document in a collection by using the MongoDB Java driver.

Copy link
Collaborator

@caitlindavey caitlindavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@norareidy norareidy merged commit d198b0f into mongodb:master Oct 18, 2023
@norareidy norareidy deleted the DOCSP-33345-java-comments-1 branch October 18, 2023 20:25
norareidy added a commit that referenced this pull request Oct 18, 2023
* DOCSP-33345: Java code comments pt. 1

* file summaries

* indicative mood

* CC edits

* CD feedback + sheet syntax

(cherry picked from commit d198b0f)
norareidy added a commit that referenced this pull request Oct 18, 2023
* DOCSP-33345: Java code comments pt. 1

* file summaries

* indicative mood

* CC edits

* CD feedback + sheet syntax

(cherry picked from commit d198b0f)
norareidy added a commit that referenced this pull request Oct 18, 2023
* DOCSP-33345: Java code comments pt. 1

* file summaries

* indicative mood

* CC edits

* CD feedback + sheet syntax

(cherry picked from commit d198b0f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants