-
Notifications
You must be signed in to change notification settings - Fork 43
DOCSP-33345: Java code comments pt. 1 #469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-33345: Java code comments pt. 1 #469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments about the summary comments at the top of each file. Once those changes are made it can be approved. Thanks!
@@ -1,3 +1,9 @@ | |||
/** | |||
* This file demonstrates MongoDB bulk write operations by using the Java driver. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personal opinion: There's something about the "This file" that feels clunky to me. I think maybe we delete that and change to:
* This file demonstrates MongoDB bulk write operations by using the Java driver. | |
* Conduct bulk write operations by using the Java driver. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And change comment to single line comment //
@@ -1,3 +1,9 @@ | |||
/** | |||
* This file demonstrates MongoDB bulk write operations by using the Java driver. | |||
* It connects to a MongoDB deployment, accesses the "sample_mflix" database, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think delete the next two rows.
@@ -1,3 +1,9 @@ | |||
/** | |||
* This file demonstrates how to run a command by using the Java driver. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same note as above.
* This file demonstrates how to run a command by using the Java driver. | |
* // Run a command by using the MongoDB Java driver. |
@@ -1,3 +1,10 @@ | |||
/** | |||
* This file demonstrates how to perform count operations by using the Java driver. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* This file demonstrates how to perform count operations by using the Java driver. | |
* // Perform count operations by using the MongoDB Java driver. |
@@ -1,3 +1,10 @@ | |||
/** | |||
* This file demonstrates how to delete multiple documents in a collection by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* This file demonstrates how to delete multiple documents in a collection by | |
* // Delete multiple documents in a collection using the MongoDB Java driver. |
* This file demonstrates how to delete a document in a collection by using the | ||
* Java driver. | ||
* The file connects to a MongoDB deployment, accesses the "sample_mflix" database, | ||
* and deletes a document in the "movies" collection based on a specified query. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* This file demonstrates how to delete a document in a collection by using the | |
* Java driver. | |
* The file connects to a MongoDB deployment, accesses the "sample_mflix" database, | |
* and deletes a document in the "movies" collection based on a specified query. | |
*/ | |
* // Delete a document in a collection by using the MongoDB Java driver. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* DOCSP-33345: Java code comments pt. 1 * file summaries * indicative mood * CC edits * CD feedback + sheet syntax (cherry picked from commit d198b0f)
* DOCSP-33345: Java code comments pt. 1 * file summaries * indicative mood * CC edits * CD feedback + sheet syntax (cherry picked from commit d198b0f)
* DOCSP-33345: Java code comments pt. 1 * file summaries * indicative mood * CC edits * CD feedback + sheet syntax (cherry picked from commit d198b0f)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-33345
Staging:
Bulk write - https://preview-mongodbnorareidy.gatsbyjs.io/java/DOCSP-33345-java-comments-1/usage-examples/bulkWrite/
Run command - https://preview-mongodbnorareidy.gatsbyjs.io/java/DOCSP-33345-java-comments-1/usage-examples/command/
Count - https://preview-mongodbnorareidy.gatsbyjs.io/java/DOCSP-33345-java-comments-1/usage-examples/count/
DeleteOne - https://preview-mongodbnorareidy.gatsbyjs.io/java/DOCSP-33345-java-comments-1/usage-examples/deleteOne/
DeleteMany - https://preview-mongodbnorareidy.gatsbyjs.io/java/DOCSP-33345-java-comments-1/usage-examples/deleteMany/
Self-Review Checklist