-
Notifications
You must be signed in to change notification settings - Fork 43
DOCSP-33345: Java comments pt. 5 #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
norareidy
merged 5 commits into
mongodb:master
from
norareidy:DOCSP-33345-java-comments-5
Oct 27, 2023
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,12 +46,19 @@ public void go() { | |
private void nearExample() { | ||
// begin findExample | ||
|
||
// code to set up your mongo client ... | ||
// Add your MongoClient setup code here | ||
MongoDatabase database = mongoClient.getDatabase("sample_mflix"); | ||
MongoCollection<Document> collection = database.getCollection("theaters"); | ||
|
||
Point centralPark = new Point(new Position(-73.9667, 40.78)); | ||
|
||
// Creates a query that matches all locations between 5,000 and 10,000 meters from the specified Point | ||
Bson query = near("location.geo", centralPark, 10000.0, 5000.0); | ||
|
||
// Creates a projection to include only the "location.address.city" field in the results | ||
Bson projection = fields(include("location.address.city"), excludeId()); | ||
|
||
// Prints the projected field of the results from the geospatial query as JSON | ||
collection.find(query) | ||
.projection(projection) | ||
.forEach(doc -> System.out.println(doc.toJson())); | ||
|
@@ -62,14 +69,21 @@ private void rangeExample() { | |
MongoDatabase database = mongoClient.getDatabase("sample_mflix"); | ||
MongoCollection<Document> collection = database.getCollection("theaters"); | ||
// begin rangeExample | ||
// Add your MongoCollection setup code here | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Suggestion: |
||
|
||
// code to set up your mongo collection ... | ||
// Creates a set of points that defines the bounds of a geospatial shape | ||
Polygon longIslandTriangle = new Polygon(Arrays.asList(new Position(-72, 40), | ||
new Position(-74, 41), | ||
new Position(-72, 39), | ||
new Position(-72, 40))); | ||
|
||
// Creates a projection to include only the "location.address.city" field in the results | ||
Bson projection = fields(include("location.address.city"), excludeId()); | ||
|
||
// Creates a query that matches documents containing "location.geo" values within the specified bounds | ||
Bson geoWithinComparison = geoWithin("location.geo", longIslandTriangle); | ||
|
||
// Prints the projected field of the results from the geolocation query as JSON | ||
collection.find(geoWithinComparison) | ||
.projection(projection) | ||
.forEach(doc -> System.out.println(doc.toJson())); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue:
I think it could be good to only feature one Summary-type comment per method.
Suggestion:
I think omitting the Summary-type comment on line 29 ("Connects to MongoDB and retrieves a document...") would work well.