Skip to content

DOCSP-33345: Java comments pt. 8 #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

norareidy
Copy link
Contributor

@norareidy norareidy commented Oct 18, 2023

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-33345
Staging:
Codecs - https://preview-mongodbnorareidy.gatsbyjs.io/java/DOCSP-33345-java-comments-8/fundamentals/data-formats/codecs/
Queries - https://preview-mongodbnorareidy.gatsbyjs.io/java/DOCSP-33345-java-comments-8/fundamentals/crud/query-document/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?

Copy link
Collaborator

@caitlindavey caitlindavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -50,36 +50,51 @@ public static void main(String [] args){
}

private void comparisonFilter(){
// Creates a filter to match documents that have a "qty" value over 7
// begin comparisonFilter
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// begin comparisonFilter
// begin comparisonFilter

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these for includes reasons? If so, ignore the suggestion. If not, please remove.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, these are to mark the code to include

@norareidy norareidy merged commit 25176b7 into mongodb:master Oct 27, 2023
norareidy added a commit that referenced this pull request Oct 27, 2023
* DOCSP-33345: Java comments pt. 8

* small edit

* add quotes

(cherry picked from commit 25176b7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants