Skip to content

DOCSP-33951: atomic typos fy2024-q4 #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 15, 2023

Conversation

rustagir
Copy link
Contributor

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-33951
Staging - https://preview-mongodbrustagir.gatsbyjs.io/java/DOCSP-33951-javasync-alas/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

@@ -58,7 +58,7 @@ principal name.
The following code snippets show how to specify the authentication mechanism,
using the following placeholders:

* ``username`` - your URL-encoded principal name, e.g. "username%40REALM.ME"
* ``username`` - your URL-encoded principal name, for example "username%40REALM.ME"
Copy link
Contributor

@norareidy norareidy Nov 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S:

Suggested change
* ``username`` - your URL-encoded principal name, for example "username%40REALM.ME"
* ``username`` - your URL-encoded principal name, such as "username%40REALM.ME"

for more information on each class.
implement ``WriteModel`` correspond to the preceding write
operation methods. For example, the ``InsertOneModel`` class wraps the
``insertOne`` write operation. See the links to the API documentation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S:

Suggested change
``insertOne`` write operation. See the links to the API documentation
``insertOne()`` write operation. See the links to the API documentation

source/faq.txt Outdated
For example, if you have an ``Event`` class that you extend in Java,
such as ``MachineEvent`` or ``NetworkEvent``, using a discriminator
identifies which class the ``PojoCodecProvider`` must use to
serialize/deserialize the document.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S:

Suggested change
serialize/deserialize the document.
serialize and deserialize the document.

Copy link
Contributor

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + a few suggestions!

@rustagir rustagir merged commit 6c235c3 into mongodb:master Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants