DOCSP-34994: socketsettings parameter types fix #497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachel-mack
approved these changes
Jan 11, 2024
Comment on lines
+64
to
+68
| - The driver removes the following record annotations: | ||
|
|
||
| - ``BsonId`` | ||
| - ``BsonProperty`` | ||
| - ``BsonRepresentation`` |
There was a problem hiding this comment.
Was this meant to be included in this PR?
There was a problem hiding this comment.
yes I added a note in the PR description - I think this step wasnt done when you did the ticket, so just handled it here!
source/upgrade.txt
Outdated
Comment on lines
70
to
71
| - The first parameter for each of the following ``SocketSettings`` builder | ||
| methods is updated from type ``int`` to ``long``: |
There was a problem hiding this comment.
Suggestion: Add more context
Suggested change
| - The first parameter for each of the following ``SocketSettings`` builder | |
| methods is updated from type ``int`` to ``long``: | |
| - The first parameter (timeout duration) for each of the following ``SocketSettings`` builder | |
| methods is updated from type ``int`` to ``long``: |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-34994
this PR also includes content for the removal described in DOCSP-34104
Staging:
Self-Review Checklist