Skip to content

DOCSP-34122: Integrations guide #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 25, 2024

Conversation

norareidy
Copy link
Contributor

@norareidy norareidy commented Jan 24, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-34122
Staging - https://preview-mongodbnorareidy.gatsbyjs.io/java/DOCSP-34122-common-frameworks/integrations/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link
Contributor

@ccho-mongodb ccho-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking up this task. I think the framework and tool summaries demonstrate a good grasp of the information.

I think most of my comments apply to the level of detail and organization of the information. The subheadings indicated deeper information on incorporating the frameworks/tools into an application, but weren't detailed enough to perform that action. I'd recommend formulating the learning objectives of the page and finding the right level of detail that could be made consistent across the headings.

I think it would also be helpful to avoid jargon (including classnames and method names, especially since those can change without notice) and to present information concisely.


.. note::

MongoDB does not own the tools included on this page.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:
I think readers might want more specific information than ownership, such as whether MongoDB provides support for them, runs test suites to check for compatibility with them, etc. I think it could also be "important" since it could be essential information for audiences that might have some assumptions around support/compatibility.
I don't know the specifics, but I had added a comment in the ticket that they are not "official MongoDB partners" which could be one of the pieces of information surfaced in this callout.

E.g.
"These integrations are not official MongoDB partners. explain the support policy
(or lack thereof) here
"

Copy link
Contributor

@ccho-mongodb ccho-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the updates, the consistent structure helps locate info quickly!

A couple minor items to address in addition to the support policy details.

Comment on lines 62 to 64
You can use Spring Data MongoDB's template API to perform CRUD operations on MongoDB data.
Additionally, the MongoDB converter allows you to map domain objects to MongoDB documents,
and the GridFS template provides access to MongoDB's GridFS filesystem.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:
No change necessary, but I think this could be easier to find the information for each feature if presented as a list.

Quarkus also supports a variety of application styles, including HTTP microservices,
reactive applications, and serverless functions.
The `Quarkus <https://quarkus.io/>`__ Java framework supports the development of microservices
and serverless systems. Quarkus is native to `Kubernetes <https://kubernetes.io/>`__, a platform
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:

I think "serverless applications" is more commonly used and could replace the term "serverless systems".

Comment on lines 57 to 60
MongoDB databases by using a Spring-based programming model. For instructions on using
Spring Data MongoDB to build an application and interact with MongoDB, see the
`Accessing Data with MongoDB <https://spring.io/guides/gs/accessing-data-mongodb>`__ guide in
the Spring documentation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:
Related to this comment, I think the placement of "how to use this" ("For instructions...") between the "what it is" and "what are the features" parts of the information can interrupt the flow.

I think ordering the info the following way could flow better:

"What it is"
"What are the features"
"How to use this"

Applies to all the sections.

can create compact Panache entities to represent MongoDB documents. Several annotations,
including ``@MongoEntity``, ``@BsonProperty``, and ``@BsonIgnore``, allow for
customized mapping between entities and MongoDB documents.
Use the MongoDB client extension to access the following features:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:

I think it could be helpful to stay consistent in each section with whether imperative mood (either using it or not using it) is used when presenting the features in each section. I think either way (Spring Data "You can use..." or Quarkus "Use the ...") works.

the Spring documentation.

You can use Spring Data MongoDB's template API to perform CRUD operations on MongoDB data.
Additionally, the MongoDB converter allows you to map domain objects to MongoDB documents,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue:
From the style guide entry on terminology:

Use allow only when discussing permission. Avoid using allow to imply that a program, feature, or product permits a user to do something. Use you can instead. Enables is also acceptable.

Suggestion:

I think replacing "allows" with "enables" would follow the style guide guidance.

Applies to all instances.

@ashni-mehta ashni-mehta self-requested a review March 12, 2024 15:17
Spring Data MongoDB enables you to access MongoDB databases by using a Spring-based programming
model.

You can use Spring Data MongoDB's template API to perform the following actions:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spring Data supports a bunch of MongoDB capabilities outside of CRUD. Could we call out that Atlas Search is supported, as well as CSFLE?

Copy link

@ashni-mehta ashni-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments, mostly in the Spring section.


.. important::

The integrations on this page are not official MongoDB partners.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could change language here slightly to say something like:

"The integrations on this page are not officially developed by MongoDB" or
"The integrations on this page are not developed by official MongoDB partners" or
"The open-source integrations listed below are all community-developed and maintained."

To clarify that the integrations themselves are not the partners, but rather are not developed by us / our partners?

- Access MongoDB's GridFS filesystem using the GridFS template

For instructions on using Spring Data MongoDB to build an application and interact with MongoDB, see the
`Accessing Data with MongoDB <https://spring.io/guides/gs/accessing-data-mongodb>`__ guide in

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how up to date this information is given that there's an open issue asking to upgrade to the latest version of the Spring documentation. Could we link to this page instead in the reference documentation?

[https://docs.spring.io/spring-data/mongodb/reference/mongodb/getting-started.html]

@norareidy norareidy requested a review from ashni-mehta April 25, 2024 15:24
Copy link

@ashni-mehta ashni-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @norareidy !

@norareidy norareidy merged commit eafcda6 into mongodb:master Apr 25, 2024
@norareidy norareidy deleted the DOCSP-34122-common-frameworks branch April 25, 2024 17:35
norareidy added a commit that referenced this pull request Apr 25, 2024
* first draft

* edits

* page format, toc

* edits, ownership

* wording

* rewording, edits

* more wording changes

* moving location on TOC

* most CC feedback

* wording

* more wording

* CC feedback pt 2

* edits

* build

* AM feedback

* build log fix

* Revert "build log fix"

This reverts commit b52c017.

(cherry picked from commit eafcda6)
norareidy added a commit that referenced this pull request Apr 25, 2024
* first draft

* edits

* page format, toc

* edits, ownership

* wording

* rewording, edits

* more wording changes

* moving location on TOC

* most CC feedback

* wording

* more wording

* CC feedback pt 2

* edits

* build

* AM feedback

* build log fix

* Revert "build log fix"

This reverts commit b52c017.

(cherry picked from commit eafcda6)
norareidy added a commit that referenced this pull request Apr 25, 2024
* first draft

* edits

* page format, toc

* edits, ownership

* wording

* rewording, edits

* more wording changes

* moving location on TOC

* most CC feedback

* wording

* more wording

* CC feedback pt 2

* edits

* build

* AM feedback

* build log fix

* Revert "build log fix"

This reverts commit b52c017.

(cherry picked from commit eafcda6)
norareidy added a commit that referenced this pull request Apr 25, 2024
* first draft

* edits

* page format, toc

* edits, ownership

* wording

* rewording, edits

* more wording changes

* moving location on TOC

* most CC feedback

* wording

* more wording

* CC feedback pt 2

* edits

* build

* AM feedback

* build log fix

* Revert "build log fix"

This reverts commit b52c017.

(cherry picked from commit eafcda6)
norareidy added a commit that referenced this pull request Apr 25, 2024
* first draft

* edits

* page format, toc

* edits, ownership

* wording

* rewording, edits

* more wording changes

* moving location on TOC

* most CC feedback

* wording

* more wording

* CC feedback pt 2

* edits

* build

* AM feedback

* build log fix

* Revert "build log fix"

This reverts commit b52c017.

(cherry picked from commit eafcda6)
norareidy added a commit that referenced this pull request Apr 25, 2024
* first draft

* edits

* page format, toc

* edits, ownership

* wording

* rewording, edits

* more wording changes

* moving location on TOC

* most CC feedback

* wording

* more wording

* CC feedback pt 2

* edits

* build

* AM feedback

* build log fix

* Revert "build log fix"

This reverts commit b52c017.

(cherry picked from commit eafcda6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants