-
Notifications
You must be signed in to change notification settings - Fork 43
[Java] Breaking change for timeout parameters for SocketSettings builder methods #519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
0fd9305
tech review
rachel-mack ebbd07e
tech review
rachel-mack e354d89
JY review
rachel-mack e9c688b
VK review
rachel-mack f6cd070
JY review
rachel-mack d76f95c
VK review
rachel-mack 14cf979
VK review
rachel-mack 8dd1ad2
tweak
rachel-mack 5409776
breaking change to socketsettings
rachel-mack 80192ed
tweaks
rachel-mack 8163358
tweaks
rachel-mack 6103ff0
tweaks
rachel-mack 4502b79
tweaks
rachel-mack 2c6098d
tweaks
rachel-mack 42962e1
tweaks
rachel-mack ff0f60c
JS review
rachel-mack File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: make parameters singular so it doesn't read like it's multiple for each one