Skip to content

DOCSP-39269: Add OIDC to What's New #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2024

Conversation

norareidy
Copy link
Contributor

@norareidy norareidy commented May 6, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-39269
Staging - https://preview-mongodbnorareidy.gatsbyjs.io/java/DOCSP-39269-oidc-whats-new/whats-new/#what-s-new-in-5.1

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

@@ -69,6 +69,8 @@ Improvements in 5.1

- Internal testing of GraalVM native image technology. These tests involve building
native applications by using the GraalVM native-image tool.
- Enhanced support for the MONGODB-OIDC authentication mechanism. For more information about
OIDC, see the :ref:`mongodb-oidc` section of the Enterprise Authentication Mechanisms guide.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicking this link takes me to /fundamentals/enterprise-auth/#std-label-mongodb-oidc as opposed to /fundamentals/enterprise-auth/#mongodb-oidc, which lead to slightly different locations on the page (the latter feels like it would be the correct anchor link). Is this expected behavior?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we use ref anchors to link to other pages, the std-label part of the link is expected. It is weird that the link brings you a little before the start of the MONGODB-OIDC section, but I'm not sure if there's a way around this - think it's just strange Snooty behavior.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, LGTM!

@norareidy norareidy requested a review from mcmorisi May 6, 2024 18:06
@norareidy norareidy requested review from a team and vbabanin and removed request for a team May 6, 2024 18:11
@norareidy norareidy merged commit 8701b75 into mongodb:master May 8, 2024
2 checks passed
@norareidy norareidy deleted the DOCSP-39269-oidc-whats-new branch May 8, 2024 14:26
norareidy added a commit that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants