Skip to content

DOCSP-38823: Insert docs with geospatial data #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2024

Conversation

norareidy
Copy link
Contributor

@norareidy norareidy commented May 8, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-38823
Staging - https://preview-mongodbnorareidy.gatsbyjs.io/java/DOCSP-38823-insert-doc-geospatial/fundamentals/crud/read-operations/geo/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link
Contributor

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ a few suggestions

Insert a Document Containing GeoJSON Data
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

To insert a document that stores GeoJSON data, specify a document that contains a GeoJSON
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: to me, "specify a document" is a little funny on its own like this. looks like you used "create a document" in the next section; i think that works better

Suggested change
To insert a document that stores GeoJSON data, specify a document that contains a GeoJSON
To insert a document that stores GeoJSON data, create a document that contains a GeoJSON

value and pass the document to the ``insertOne()`` method.

The following example inserts a document that includes a ``location.geo`` field,
which stores GeoJSON data:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
which stores GeoJSON data:
which contains GeoJSON data:

``insertOne()`` method.

The following example inserts a document that includes a ``coordinates`` field,
which stores geospatial data as a legacy coordinate pair:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
which stores geospatial data as a legacy coordinate pair:
which contains geospatial data as a legacy coordinate pair:

@norareidy norareidy requested review from a team and katcharov and removed request for a team May 9, 2024 15:31
Copy link
Collaborator

@katcharov katcharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@norareidy norareidy merged commit fd068c9 into mongodb:master May 31, 2024
2 checks passed
@norareidy norareidy deleted the DOCSP-38823-insert-doc-geospatial branch May 31, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants