Skip to content

DOCSP-30349: server selection errors #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 3, 2024

Conversation

rustagir
Copy link
Contributor

@rustagir rustagir commented May 30, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-30349
Staging - https://preview-mongodbrustagir.gatsbyjs.io/java/DOCSP-30349-server-sel-errors/connection-troubleshooting/#server-selection-timeout-exceptions

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link
Contributor

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a suggestion

Comment on lines 239 to 240
the request timed out as MongoDB was unable to select a server that
satisfied the read preference of ``primary``. In this situation, reads
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: I think this sentence still makes sense if you change to present tense:

Suggested change
the request timed out as MongoDB was unable to select a server that
satisfied the read preference of ``primary``. In this situation, reads
the request times out as MongoDB is unable to select a server that
satisfies the read preference of ``primary``. In this situation, reads

@rustagir rustagir requested review from a team and jyemin and removed request for a team May 30, 2024 17:13
Server Selection Errors
-----------------------

MongoDB might not be able to complete a request even when some servers
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
MongoDB might not be able to complete a request even when some servers
Your application might not be able to complete a request even when some servers

@rustagir rustagir requested a review from jyemin May 30, 2024 19:30
Copy link
Collaborator

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rustagir rustagir merged commit aad1fae into mongodb:master Jun 3, 2024
2 checks passed
rustagir added a commit that referenced this pull request Jun 3, 2024
* DOCSP-30349: server sel errors

* NR PR fixes 1

* JY tech review

* fixes

* anchor

* vale fix

(cherry picked from commit aad1fae)
rustagir added a commit that referenced this pull request Jun 3, 2024
* DOCSP-30349: server sel errors

* NR PR fixes 1

* JY tech review

* fixes

* anchor

* vale fix

(cherry picked from commit aad1fae)
rustagir added a commit that referenced this pull request Jun 3, 2024
* DOCSP-30349: server sel errors

* NR PR fixes 1

* JY tech review

* fixes

* anchor

* vale fix

(cherry picked from commit aad1fae)
rustagir added a commit that referenced this pull request Jun 3, 2024
* DOCSP-30349: server sel errors

* NR PR fixes 1

* JY tech review

* fixes

* anchor

* vale fix

(cherry picked from commit aad1fae)
rustagir added a commit that referenced this pull request Jun 3, 2024
* DOCSP-30349: server sel errors

* NR PR fixes 1

* JY tech review

* fixes

* anchor

* vale fix

(cherry picked from commit aad1fae)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants