-
Notifications
You must be signed in to change notification settings - Fork 43
DOCSP-40062: BsonProperty getters/setters #561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-40062: BsonProperty getters/setters #561
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one comment!
| When applying ``@BsonProperty`` to a private field, you must also add | ||
getter and setter methods for that field to serialize and customize | ||
the field name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice some of the other Description cells in this table have a Tip box enclosed within – might be a good idea to enclose the second paragraph in a Note box?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that idea - updated!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* DOCSP-40062: BsonProperty getters/setters * MM feedback (cherry picked from commit 06681df)
* DOCSP-40062: BsonProperty getters/setters * MM feedback (cherry picked from commit 06681df)
* DOCSP-40062: BsonProperty getters/setters * MM feedback (cherry picked from commit 06681df)
* DOCSP-40062: BsonProperty getters/setters * MM feedback (cherry picked from commit 06681df)
* DOCSP-40062: BsonProperty getters/setters * MM feedback (cherry picked from commit 06681df)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-40062
Staging - https://preview-mongodbnorareidy.gatsbyjs.io/java/DOCSP-40062-fix-annotation/fundamentals/data-formats/pojo-customization/
Self-Review Checklist