Skip to content

DOCSP-40062: BsonProperty getters/setters #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

norareidy
Copy link
Contributor

@norareidy norareidy commented Jul 11, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-40062
Staging - https://preview-mongodbnorareidy.gatsbyjs.io/java/DOCSP-40062-fix-annotation/fundamentals/data-formats/pojo-customization/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link
Contributor

@mcmorisi mcmorisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment!

Comment on lines 305 to 307
| When applying ``@BsonProperty`` to a private field, you must also add
getter and setter methods for that field to serialize and customize
the field name.
Copy link
Contributor

@mcmorisi mcmorisi Jul 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice some of the other Description cells in this table have a Tip box enclosed within – might be a good idea to enclose the second paragraph in a Note box?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that idea - updated!

@norareidy norareidy requested review from a team and rozza and removed request for a team July 11, 2024 17:50
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@norareidy norareidy merged commit 06681df into mongodb:master Jul 16, 2024
2 checks passed
@norareidy norareidy deleted the DOCSP-40062-fix-annotation branch July 16, 2024 13:56
norareidy added a commit that referenced this pull request Jul 16, 2024
* DOCSP-40062: BsonProperty getters/setters

* MM feedback

(cherry picked from commit 06681df)
norareidy added a commit that referenced this pull request Jul 16, 2024
* DOCSP-40062: BsonProperty getters/setters

* MM feedback

(cherry picked from commit 06681df)
norareidy added a commit that referenced this pull request Jul 16, 2024
* DOCSP-40062: BsonProperty getters/setters

* MM feedback

(cherry picked from commit 06681df)
norareidy added a commit that referenced this pull request Jul 16, 2024
* DOCSP-40062: BsonProperty getters/setters

* MM feedback

(cherry picked from commit 06681df)
norareidy added a commit that referenced this pull request Jul 16, 2024
* DOCSP-40062: BsonProperty getters/setters

* MM feedback

(cherry picked from commit 06681df)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants