Skip to content

DOCSP-42372: Change username and password placeholders #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

mcmorisi
Copy link
Contributor

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-42372
Staging - https://preview-mongodbmcmorisi.gatsbyjs.io/java/DOCSP-42372-username-password/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?

Copy link
Contributor

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm + a couple things!

Comment on lines 433 to 434
.. literalinclude::
:language: csharp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I: This code block is no longer rendering on the staging site - I think you can just change it back to how it was

Copy link
Contributor Author

@mcmorisi mcmorisi Aug 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why so many unrelated changes/modifications/deletions got included in this commit, let me investigate to make sure I pulled in the latest changes correctly

@@ -66,7 +66,7 @@ to learn how to allow connections to your instance of Atlas and to find the
:manual:`connection string </reference/connection-string/>` you use to replace the
``uri`` variable in usage examples. If your instance uses
:manual:`SCRAM authentication </core/security-scram/>`, you can replace
``<user>`` with your username, ``<password>`` with your password, and
``<db_username>`` with your username, ``<db_password>`` with your password, and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S:

Suggested change
``<db_username>`` with your username, ``<db_password>`` with your password, and
``<db_username>`` with your database username, ``<db_password>`` with your database password, and

@mcmorisi mcmorisi merged commit f4b9ab8 into mongodb:master Aug 12, 2024
2 checks passed
@mcmorisi mcmorisi deleted the DOCSP-42372-username-password branch August 12, 2024 19:33
mcmorisi added a commit that referenced this pull request Aug 12, 2024
DOCSP-42372: Change username and password placeholders
mcmorisi added a commit that referenced this pull request Aug 12, 2024
DOCSP-42372: Change username and password placeholders
mcmorisi added a commit that referenced this pull request Aug 12, 2024
DOCSP-42372: Change username and password placeholders
mcmorisi added a commit that referenced this pull request Aug 12, 2024
DOCSP-42372: Change username and password placeholders
mcmorisi added a commit that referenced this pull request Aug 12, 2024
DOCSP-42372: Change username and password placeholders
mcmorisi added a commit that referenced this pull request Aug 12, 2024
DOCSP-42372: Change username and password placeholders
mcmorisi added a commit that referenced this pull request Aug 12, 2024
DOCSP-42372: Change username and password placeholders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants