-
Notifications
You must be signed in to change notification settings - Fork 43
DOCSP-41762 Add transactions page #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-41762 Add transactions page #569
Conversation
✅ Deploy Preview for docs-java ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! great job responding to the feedback!
@stIncMale tagging in case this fell off your radar. I know there have been a lot of Java-related docs review requests coming up. |
Also tagging @rozza in case you have the bandwidth for technical review; I noticed you reviewed a similar page for Java RS. |
|
||
// Use withTransaction and lambda for transaction operations | ||
session.withTransaction(() -> { | ||
collection.insertMany(session, Arrays.asList( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a note / important block in the documentation reminding users that they must include the session as a parameter for the operation to be part of the transaction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this callout. Adding an admonition to the Overview section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
add transaction page and code snippet (cherry picked from commit e0ad954)
add transaction page and code snippet (cherry picked from commit e0ad954)
add transaction page and code snippet (cherry picked from commit e0ad954)
add transaction page and code snippet (cherry picked from commit e0ad954)
add transaction page and code snippet (cherry picked from commit e0ad954)
add transaction page and code snippet (cherry picked from commit e0ad954)
add transaction page and code snippet (cherry picked from commit e0ad954)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-41762
Staging - https://deploy-preview-569--docs-java.netlify.app/fundamentals/transactions/
Self-Review Checklist