Skip to content

DOCSP-41762 Add transactions page #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 18, 2024

Conversation

stephmarie17
Copy link
Contributor

@stephmarie17 stephmarie17 commented Aug 22, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-41762
Staging - https://deploy-preview-569--docs-java.netlify.app/fundamentals/transactions/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for docs-java ready!

Name Link
🔨 Latest commit de25e0c
🔍 Latest deploy log https://app.netlify.com/sites/docs-java/deploys/66e99f394df15c0008333e94
😎 Deploy Preview https://deploy-preview-569--docs-java.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stephmarie17 stephmarie17 marked this pull request as ready for review August 23, 2024 17:50
@rustagir rustagir self-requested a review August 26, 2024 17:33
@stephmarie17 stephmarie17 requested a review from rustagir August 26, 2024 20:15
@stephmarie17 stephmarie17 requested a review from rustagir August 26, 2024 22:46
Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! great job responding to the feedback!

@stephmarie17 stephmarie17 requested review from a team and stIncMale and removed request for a team August 29, 2024 15:28
@stephmarie17
Copy link
Contributor Author

@stIncMale tagging in case this fell off your radar. I know there have been a lot of Java-related docs review requests coming up.

@stephmarie17
Copy link
Contributor Author

Also tagging @rozza in case you have the bandwidth for technical review; I noticed you reviewed a similar page for Java RS.


// Use withTransaction and lambda for transaction operations
session.withTransaction(() -> {
collection.insertMany(session, Arrays.asList(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a note / important block in the documentation reminding users that they must include the session as a parameter for the operation to be part of the transaction.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this callout. Adding an admonition to the Overview section.

@stephmarie17 stephmarie17 requested a review from rozza September 17, 2024 15:28
@jyemin jyemin removed the request for review from stIncMale September 17, 2024 20:15
@jyemin
Copy link
Collaborator

jyemin commented Sep 17, 2024

Removing @vbabanin since @rozza is on it.

Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephmarie17 stephmarie17 merged commit e0ad954 into mongodb:master Sep 18, 2024
6 checks passed
stephmarie17 added a commit that referenced this pull request Sep 18, 2024
add transaction page and code snippet

(cherry picked from commit e0ad954)
stephmarie17 added a commit that referenced this pull request Sep 18, 2024
add transaction page and code snippet

(cherry picked from commit e0ad954)
stephmarie17 added a commit that referenced this pull request Sep 18, 2024
add transaction page and code snippet

(cherry picked from commit e0ad954)
stephmarie17 added a commit that referenced this pull request Sep 18, 2024
add transaction page and code snippet

(cherry picked from commit e0ad954)
stephmarie17 added a commit that referenced this pull request Sep 18, 2024
add transaction page and code snippet

(cherry picked from commit e0ad954)
stephmarie17 added a commit that referenced this pull request Sep 18, 2024
add transaction page and code snippet

(cherry picked from commit e0ad954)
stephmarie17 added a commit that referenced this pull request Sep 18, 2024
add transaction page and code snippet

(cherry picked from commit e0ad954)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants