-
Notifications
You must be signed in to change notification settings - Fork 43
DOCSP-47031 Connection Pools #620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-java ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few tweaks:
The following code creates a client with a maximum connection pool size of ``50`` | ||
by using either a :guilabel:`Connection String` or :guilabel:`MongoClientSettings` | ||
object: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't seen :guilabel:
used before? I guess it just bold the text?
Anyway, would make these links to the Connection Options
and MongoClient Settings
pages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rachel-mack Thanks for the below comments! The links to these pages can be found in the tabs. Since the links are now in a more content relevant place in the tabs, I think leaving without a link here is appropriate.
guilabel can be used when referring to UI components on the page (such as the tabs) or in the Atlas UI. Here are a few examples I've seen:
- https://github.com/mongodb/docs-java/blob/52989b698e6f0d9cd350bcdf018b3e0f6122c792/source/security/enterprise-auth.txt#L71C1-L71C76
- https://github.com/mongodb/docs-ruby/blob/88c9d5c460caa4fa1f57d12752f82d35e05a1522/source/security/auth-mechanisms/ldap.txt#L53
Updated the copy to specifically mention the tabs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general there is not much guidance here on why you would set any of these properties to a non-default value, but if we're not trying to explain that, than I can accept it. It would certainly require a lot more thought, as there are no strict rules to follow.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-47031
Staging Links
Self-Review Checklist