-
Notifications
You must be signed in to change notification settings - Fork 43
DOCSP-47042 Monitoring Edits #633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-java ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi @stIncMale, thanks for reviewing! Can you please let me know the following:
|
Monitoring is the process of getting information about the activities a | ||
running program performs for use in an application or an application performance | ||
management library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wording seems awkward. In particular, I am not sure what it means to get "information ... for use in an application".
Possible reword, which may or may not capture the intended meaning:
Monitoring involves collecting information about the activities of a running program, which can be used to support application development or in an application performance management library.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the potential reword! What do you think about this:
Monitoring involves collecting information about the activities of a running program,
which you can use in your application or with an application performance management
library.
Monitoring your application lets you understand the driver's resource usage | ||
and performance and can help you make informed | ||
decisions when designing and debugging your application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the prior focus on the driver seemed clearer. None of the monitoring discussed is app-level, it is all driver level?
|
||
This guide shows how to use information about the activity of the driver in code. | ||
If you would like to learn how to record events in the driver, | ||
consider reading our :doc:`guide on logging </logging>`. | ||
To learn how to record events in the driver, see the {+driver-short+}'s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice word reductions, these help clarity 👍
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-47042
Staging Links
Self-Review Checklist