Skip to content

DOCSP-47923 Kubernetes for OIDC #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2025

Conversation

lindseymoore
Copy link
Collaborator

@lindseymoore lindseymoore commented Feb 27, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-47923

Staging Links

  • security/auth/oidc
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented Feb 27, 2025

    Deploy Preview for docs-java ready!

    Name Link
    🔨 Latest commit 75f86de
    🔍 Latest deploy log https://app.netlify.com/sites/docs-java/deploys/67cf38ec514c0e0008734b13
    😎 Deploy Preview https://deploy-preview-640--docs-java.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link
    Contributor

    @mongoKart mongoKart left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Content looks good, but it should be moved to the OIDC section

    Copy link
    Contributor

    @mongoKart mongoKart left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    lgtm!

    @lindseymoore lindseymoore requested review from a team and katcharov and removed request for a team March 4, 2025 15:07
    @lindseymoore lindseymoore requested a review from katcharov March 7, 2025 20:38
    @lindseymoore
    Copy link
    Collaborator Author

    lindseymoore commented Mar 7, 2025

    Thanks @katcharov, I added the MongoCredential section. Can you please verify whether a username is required for the createOidcCredential() method for Kubernetes? Is it ok to leave the method without any input rather than putting null? Thanks!

    @katcharov
    Copy link
    Collaborator

    Looks like we have the following tests:

        {
          "description": "should throw an error for a username and password with gcp provider (MONGODB-OIDC)",
          "uri": "mongodb://user:pass@localhost/?authMechanism=MONGODB-OIDC&authMechanismProperties=ENVIRONMENT:gcp,TOKEN_RESOURCE:foo",
          "valid": false,
          "credential": null
        },
        {
          "description": "should throw an error for a username and password with k8s provider (MONGODB-OIDC)",
          "uri": "mongodb://user:pass@localhost/?authMechanism=MONGODB-OIDC&authMechanismProperties=ENVIRONMENT:k8s",
          "valid": false,
          "credential": null
        }
    

    Only azure supports username.

    (Password is not accepted for any OIDC.)

    @lindseymoore lindseymoore requested a review from katcharov March 7, 2025 22:23
    @lindseymoore lindseymoore merged commit 5a3f648 into mongodb:master Mar 10, 2025
    6 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants