-
Notifications
You must be signed in to change notification settings - Fork 52
v6.15 release #1036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v6.15 release #1036
Conversation
✅ Deploy Preview for docs-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm % minor suggestions! can take another look if needed
@@ -1,6 +1,6 @@ | |||
define: prefix docs/drivers/node | |||
define: base https://www.mongodb.com/${prefix} | |||
define: versions v3.6 v3.7 v4.0 v4.1 v4.2 v4.3 v4.4 v4.5 v4.6 v4.7 v4.8 v4.9 v4.10 v4.11 v4.12 v4.13 v4.14 v4.15 v4.16 v4.17 v5.0 v5.1 v5.2 v5.3 v5.4 v5.5 v5.6 v5.7 v5.8 v5.9 v6.0 v6.1 v6.2 v6.3 v6.4 v6.5 v6.6 v6.7 v6.8 v6.9 v6.10 v6.11 v6.12 6.13 6.14 master | |||
define: versions v3.6 v3.7 v4.0 v4.1 v4.2 v4.3 v4.4 v4.5 v4.6 v4.7 v4.8 v4.9 v4.10 v4.11 v4.12 v4.13 v4.14 v4.15 v4.16 v4.17 v5.0 v5.1 v5.2 v5.3 v5.4 v5.5 v5.6 v5.7 v5.8 v5.9 v6.0 v6.1 v6.2 v6.3 v6.4 v6.5 v6.6 v6.7 v6.8 v6.9 v6.10 v6.11 v6.12 6.13 6.14 6.15 master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S; maybe we can remove some of these now that they are off domain in the legacy docs dropdown? Perhaps consult with DOP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll consult with DOP and we can do this in a separate ticket if necessary
source/whats-new.txt
Outdated
|
||
- Adds support for supplying custom AWS credentials when configuring :ref:`authentication | ||
<node-authentication-mechanisms>` or :ref:`In-Use Encryption <node-fle>`. You | ||
must supply the custom function signature in the form of ``() => Promise<AWS.Credentials>``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: consider extracting this into a code-block
source/whats-new.txt
Outdated
customize your options. To view examples of how to provide custom | ||
credentials, see the :github:`v6.15.0 Release Notes | ||
<mongodb/node-mongodb-native/releases/tag/v6.15.0>` on GitHub. | ||
- Fixes bugs that caused unhandled internal testing rejections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: Can you make it more clear how this might affect the end user? It looks likethere might have been errors being returned to the user according to the release notes. You might want to change this language from suggesting the change is internal only
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-48533
Staging - What's New
Compatibility
Self-Review Checklist