Skip to content

DOCSP-28558: connection pool faq + reuse client tip #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 6, 2023
Merged

DOCSP-28558: connection pool faq + reuse client tip #636

merged 8 commits into from
Apr 6, 2023

Conversation

rustagir
Copy link
Collaborator

@rustagir rustagir commented Apr 3, 2023

Pull Request Info

PR Reviewing Guidelines

JIRA - DOCSP-28558
Staging - FAQ | Connection Guide

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?

DBirtolo-mdb
DBirtolo-mdb suggested changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@DBirtolo-mdb DBirtolo-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just a few suggestions and questions.

@rustagir rustagir requested a review from DBirtolo-mdb April 4, 2023 15:06
DBirtolo-mdb
DBirtolo-mdb approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@DBirtolo-mdb DBirtolo-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nbbeeken
nbbeeken reviewed Apr 6, 2023
View reviewed changes
source/faq.txt Outdated
Comment on lines 95 to 97
When ``MongoClient.close()`` is called by any request, the driver
closes all idle sockets and closes all sockets that are in
use as they are returned to the pool.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expand this sentence just a bit because it captures an important detail:
"closes all sockets that are in use as they are returned to the pool." Meaning we won't interrupt in progress operations. This has a unique downside for Node.js users that their process won't exit if say a slowQuery find is still pending results.

Related issue https://jira.mongodb.org/browse/NODE-3263
We have no clean solution yet because there is risk to an API that cancels operations client side without making clear the impacts (think: unacknowledged write, without actually asking for it to be unacknowledged). There is a future where client-side operation timeout may provide an avenue for users to put a global cap on operation time, so that would provide an avenue for pending operations to be closed at least on some kind of deadline.

TL;DR: I just think the "as returned" should be hoisted more in the phrasing b/c of its significance to our users.

@rustagir rustagir merged commit 9343c30 into mongodb:master Apr 6, 2023
rustagir added a commit that referenced this pull request Apr 6, 2023
@rustagir
DOCSP-28558: connection pool faq + reuse client tip (#636)
2e9dd68 
* DOCSP-28558: connection pool + reuse client

* first pass fixes

* DB PR fixes 1

* small fixes

* fixes

* wording fix

* capitalization

(cherry picked from commit 9343c30)
rustagir added a commit that referenced this pull request Apr 6, 2023
@rustagir
DOCSP-28558: connection pool faq + reuse client tip (#636)
3073322 
* DOCSP-28558: connection pool + reuse client

* first pass fixes

* DB PR fixes 1

* small fixes

* fixes

* wording fix

* capitalization

(cherry picked from commit 9343c30)
rustagir added a commit that referenced this pull request Apr 6, 2023
@rustagir
DOCSP-28558: connection pool faq + reuse client tip (#636)
0d50791 
* DOCSP-28558: connection pool + reuse client

* first pass fixes

* DB PR fixes 1

* small fixes

* fixes

* wording fix

* capitalization

(cherry picked from commit 9343c30)
rustagir added a commit that referenced this pull request Apr 6, 2023
@rustagir
DOCSP-28558: connection pool faq + reuse client tip (#636)
9c84549 
* DOCSP-28558: connection pool + reuse client

* first pass fixes

* DB PR fixes 1

* small fixes

* fixes

* wording fix

* capitalization

(cherry picked from commit 9343c30)
rustagir added a commit that referenced this pull request Apr 6, 2023
@rustagir
DOCSP-28558: connection pool faq + reuse client tip (#636)
f9ce6c9 
* DOCSP-28558: connection pool + reuse client

* first pass fixes

* DB PR fixes 1

* small fixes

* fixes

* wording fix

* capitalization

(cherry picked from commit 9343c30)
(cherry picked from commit 9c84549)
rustagir added a commit that referenced this pull request Apr 6, 2023
@rustagir
DOCSP-28558: connection pool faq + reuse client tip (#636)
0b5c445 
* DOCSP-28558: connection pool + reuse client

* first pass fixes

* DB PR fixes 1

* small fixes

* fixes

* wording fix

* capitalization

(cherry picked from commit 9343c30)
(cherry picked from commit 9c84549)
rustagir added a commit that referenced this pull request Apr 6, 2023
@rustagir
DOCSP-28558: connection pool faq + reuse client tip (#636)
9e97c4f 
* DOCSP-28558: connection pool + reuse client

* first pass fixes

* DB PR fixes 1

* small fixes

* fixes

* wording fix

* capitalization

(cherry picked from commit 9343c30)
(cherry picked from commit 9c84549)
rustagir added a commit that referenced this pull request Apr 6, 2023
@rustagir
DOCSP-28558: connection pool faq + reuse client tip (#636)
03c4c06 
* DOCSP-28558: connection pool + reuse client

* first pass fixes

* DB PR fixes 1

* small fixes

* fixes

* wording fix

* capitalization

(cherry picked from commit 9343c30)
(cherry picked from commit 9c84549)
rustagir added a commit that referenced this pull request Apr 6, 2023
@rustagir
DOCSP-28558: connection pool faq + reuse client tip (#636)
eee4e62 
* DOCSP-28558: connection pool + reuse client

* first pass fixes

* DB PR fixes 1

* small fixes

* fixes

* wording fix

* capitalization

(cherry picked from commit 9343c30)
(cherry picked from commit 9c84549)
rustagir added a commit that referenced this pull request Apr 6, 2023
@rustagir
DOCSP-28558: connection pool faq + reuse client tip (#636)
8693bb9 
* DOCSP-28558: connection pool + reuse client

* first pass fixes

* DB PR fixes 1

* small fixes

* fixes

* wording fix

* capitalization

(cherry picked from commit 9343c30)
(cherry picked from commit 9c84549)
rustagir added a commit that referenced this pull request Apr 6, 2023
@rustagir
DOCSP-28558: connection pool faq + reuse client tip (#636)
65942de 
* DOCSP-28558: connection pool + reuse client

* first pass fixes

* DB PR fixes 1

* small fixes

* fixes

* wording fix

* capitalization

(cherry picked from commit 9343c30)
(cherry picked from commit 9c84549)
rustagir added a commit that referenced this pull request Apr 6, 2023
@rustagir
DOCSP-28558: connection pool faq + reuse client tip (#636)
3b7e0ab 
* DOCSP-28558: connection pool + reuse client

* first pass fixes

* DB PR fixes 1

* small fixes

* fixes

* wording fix

* capitalization

(cherry picked from commit 9343c30)
(cherry picked from commit 9c84549)
rustagir added a commit that referenced this pull request Apr 6, 2023
@rustagir
DOCSP-28558: connection pool faq + reuse client tip (#636)
d935e0e 
* DOCSP-28558: connection pool + reuse client

* first pass fixes

* DB PR fixes 1

* small fixes

* fixes

* wording fix

* capitalization

(cherry picked from commit 9343c30)
(cherry picked from commit 9c84549)
rustagir added a commit that referenced this pull request Apr 6, 2023
@rustagir
DOCSP-28558: connection pool faq + reuse client tip (#636)
2d0172e 
* DOCSP-28558: connection pool + reuse client

* first pass fixes

* DB PR fixes 1

* small fixes

* fixes

* wording fix

* capitalization

(cherry picked from commit 9343c30)
(cherry picked from commit 9c84549)
rustagir added a commit that referenced this pull request Apr 6, 2023
@rustagir
DOCSP-28558: connection pool faq + reuse client tip (#636)
794d4d1 
* DOCSP-28558: connection pool + reuse client

* first pass fixes

* DB PR fixes 1

* small fixes

* fixes

* wording fix

* capitalization

(cherry picked from commit 9343c30)
(cherry picked from commit 9c84549)
rustagir added a commit that referenced this pull request Apr 6, 2023
@rustagir
DOCSP-28558: connection pool faq + reuse client tip (#636)
a171264 
* DOCSP-28558: connection pool + reuse client

* first pass fixes

* DB PR fixes 1

* small fixes

* fixes

* wording fix

* capitalization

(cherry picked from commit 9343c30)
(cherry picked from commit 9c84549)
rustagir added a commit that referenced this pull request Apr 6, 2023
@rustagir
DOCSP-28558: connection pool faq + reuse client tip (#636)
cafb57b 
* DOCSP-28558: connection pool + reuse client

* first pass fixes

* DB PR fixes 1

* small fixes

* fixes

* wording fix

* capitalization

(cherry picked from commit 9343c30)
(cherry picked from commit 9c84549)
rustagir added a commit that referenced this pull request Apr 6, 2023
@rustagir
DOCSP-28558: connection pool faq + reuse client tip (#636)
5671e56 
* DOCSP-28558: connection pool + reuse client

* first pass fixes

* DB PR fixes 1

* small fixes

* fixes

* wording fix

* capitalization

(cherry picked from commit 9343c30)
(cherry picked from commit 9c84549)
rustagir added a commit that referenced this pull request Apr 6, 2023
@rustagir
DOCSP-28558: connection pool faq + reuse client tip (#636)
05d9ec7 
* DOCSP-28558: connection pool + reuse client

* first pass fixes

* DB PR fixes 1

* small fixes

* fixes

* wording fix

* capitalization

(cherry picked from commit 9343c30)
(cherry picked from commit 9c84549)
(cherry picked from commit 5671e56)
rustagir added a commit that referenced this pull request Apr 6, 2023
@rustagir
DOCSP-28558: connection pool faq + reuse client tip (#636)
2a05d5c 
* DOCSP-28558: connection pool + reuse client

* first pass fixes

* DB PR fixes 1

* small fixes

* fixes

* wording fix

* capitalization

(cherry picked from commit 9343c30)
(cherry picked from commit 9c84549)
(cherry picked from commit 5671e56)
rustagir added a commit that referenced this pull request Apr 6, 2023
@rustagir
DOCSP-28558: connection pool faq + reuse client tip (#636)
53277c8 
* DOCSP-28558: connection pool + reuse client

* first pass fixes

* DB PR fixes 1

* small fixes

* fixes

* wording fix

* capitalization

(cherry picked from commit 9343c30)
(cherry picked from commit 9c84549)
(cherry picked from commit 5671e56)
jordan-smith721 pushed a commit to jordan-smith721/docs-node that referenced this pull request Jul 24, 2023
@rustagir @jordan-smith721
DOCSP-28558: connection pool faq + reuse client tip (mongodb#636)
54051d8 
* DOCSP-28558: connection pool + reuse client

* first pass fixes

* DB PR fixes 1

* small fixes

* fixes

* wording fix

* capitalization

(cherry picked from commit 9343c30)
(cherry picked from commit 9c84549)
(cherry picked from commit 5671e56)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken left review comments

@DBirtolo-mdb DBirtolo-mdb DBirtolo-mdb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rustagir @nbbeeken @DBirtolo-mdb