Skip to content

DOCSP-28958 Clarify Typescript Find and the _id section #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jordan-smith721
Copy link
Collaborator

Pull Request Info

The original wording of the section made it seem like the driver converts the _id field based on the given schema. This PR clarifies what the section was intended to convey.

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-28958
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/node/docsworker-xlarge/DOCSP-28958-typescript-find-and-id/fundamentals/typescript/#find-methods-and-the-_id-field

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?

Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + 1 suggestion. Nice job!

Comment on lines 307 to 309
the field to the specified type. The type of the fields in your type
parameter's schema should match the type of their corresponding fields in the
collection.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: Slight ambiguity

Suggested change
the field to the specified type. The type of the fields in your type
parameter's schema should match the type of their corresponding fields in the
collection.
the field to the specified type. The type of each field in your type
parameter's schema should match the type of the corresponding field in the
collection.

@jordan-smith721 jordan-smith721 merged commit a498473 into mongodb:master Apr 5, 2023
jordan-smith721 added a commit to jordan-smith721/docs-node that referenced this pull request Apr 5, 2023
jordan-smith721 added a commit to jordan-smith721/docs-node that referenced this pull request Apr 5, 2023
jordan-smith721 added a commit to jordan-smith721/docs-node that referenced this pull request Apr 5, 2023
jordan-smith721 added a commit to jordan-smith721/docs-node that referenced this pull request Apr 5, 2023
jordan-smith721 added a commit to jordan-smith721/docs-node that referenced this pull request Apr 5, 2023
jordan-smith721 added a commit to jordan-smith721/docs-node that referenced this pull request Apr 5, 2023
jordan-smith721 added a commit to jordan-smith721/docs-node that referenced this pull request Apr 5, 2023
jordan-smith721 added a commit to jordan-smith721/docs-node that referenced this pull request Apr 5, 2023
jordan-smith721 added a commit to jordan-smith721/docs-node that referenced this pull request Apr 5, 2023
jordan-smith721 added a commit to jordan-smith721/docs-node that referenced this pull request Apr 5, 2023
jordan-smith721 added a commit to jordan-smith721/docs-node that referenced this pull request Apr 5, 2023
jordan-smith721 added a commit to jordan-smith721/docs-node that referenced this pull request Apr 5, 2023
jordan-smith721 added a commit to jordan-smith721/docs-node that referenced this pull request Apr 5, 2023
jordan-smith721 added a commit to jordan-smith721/docs-node that referenced this pull request Apr 5, 2023
jordan-smith721 added a commit to jordan-smith721/docs-node that referenced this pull request Apr 5, 2023
@jordan-smith721
Copy link
Collaborator Author

💔 Some backports could not be created

Status Branch Result
v5.2
v5.1
v5.0
v4.15
v4.14
v4.13
v4.12
v4.11
v4.10
v4.9
v4.8 Could not create pull request: You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later.
v4.7 Could not create pull request: You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later.
v4.6 Could not create pull request: You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later.
v4.5 Could not create pull request: You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later.
v4.4

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

backport --pr 644

Questions ?

Please refer to the Backport tool documentation

jordan-smith721 added a commit that referenced this pull request Apr 5, 2023
jordan-smith721 added a commit that referenced this pull request Apr 5, 2023
jordan-smith721 added a commit that referenced this pull request Apr 5, 2023
jordan-smith721 added a commit that referenced this pull request Apr 5, 2023
jordan-smith721 added a commit that referenced this pull request Apr 5, 2023
jordan-smith721 added a commit that referenced this pull request Apr 5, 2023
jordan-smith721 added a commit that referenced this pull request Apr 5, 2023
jordan-smith721 added a commit that referenced this pull request Apr 5, 2023
jordan-smith721 added a commit that referenced this pull request Apr 5, 2023
jordan-smith721 added a commit that referenced this pull request Apr 5, 2023
jordan-smith721 added a commit that referenced this pull request Apr 5, 2023
jordan-smith721 added a commit that referenced this pull request Apr 5, 2023
jordan-smith721 added a commit that referenced this pull request Apr 5, 2023
jordan-smith721 added a commit that referenced this pull request Apr 5, 2023
jordan-smith721 added a commit that referenced this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants