-
Notifications
You must be signed in to change notification settings - Fork 52
DOCSP-28958 Clarify Typescript Find and the _id section #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-28958 Clarify Typescript Find and the _id section #644
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM + 1 suggestion. Nice job!
source/fundamentals/typescript.txt
Outdated
the field to the specified type. The type of the fields in your type | ||
parameter's schema should match the type of their corresponding fields in the | ||
collection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: Slight ambiguity
the field to the specified type. The type of the fields in your type | |
parameter's schema should match the type of their corresponding fields in the | |
collection. | |
the field to the specified type. The type of each field in your type | |
parameter's schema should match the type of the corresponding field in the | |
collection. |
(cherry picked from commit a498473)
(cherry picked from commit a498473)
(cherry picked from commit a498473)
(cherry picked from commit a498473)
(cherry picked from commit a498473)
(cherry picked from commit a498473)
(cherry picked from commit a498473)
(cherry picked from commit a498473)
(cherry picked from commit a498473)
(cherry picked from commit a498473)
(cherry picked from commit a498473)
(cherry picked from commit a498473)
(cherry picked from commit a498473)
(cherry picked from commit a498473)
(cherry picked from commit a498473)
💔 Some backports could not be createdNote: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
Pull Request Info
The original wording of the section made it seem like the driver converts the _id field based on the given schema. This PR clarifies what the section was intended to convey.
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-28958
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/node/docsworker-xlarge/DOCSP-28958-typescript-find-and-id/fundamentals/typescript/#find-methods-and-the-_id-field
Self-Review Checklist