DOCSP-26403: changes to aws credential retrieval #691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DBirtolo-mdb
suggested changes
May 19, 2023
Comment on lines
242
to
247
| to retrieve credentials from the environment. As a result, if you | ||
| have a shared AWS credentials file or config file, the driver will | ||
| use those credentials by default if there are no AWS authentication | ||
| environment variables set. | ||
|
|
||
| To override this behavior, you can perform one of the following actions: |
There was a problem hiding this comment.
Suggestion
I think this sentence is a little long and covers a couple of ideas, so I would recommend breaking it into two different sentences and combining it with the next line. I also reworded the second sentence a bit to put the actionable part first.
Suggested change
| to retrieve credentials from the environment. As a result, if you | |
| have a shared AWS credentials file or config file, the driver will | |
| use those credentials by default if there are no AWS authentication | |
| environment variables set. | |
| To override this behavior, you can perform one of the following actions: | |
| to retrieve credentials from the environment. As a result, if you | |
| have a shared AWS credentials file or config file, the driver will | |
| use those credentials by default. You can override this behavior | |
| by performing one of the following actions: |
Comment on lines
249
to
250
| - Set ``AWS_SHARED_CREDENTIALS_FILE`` in your shell or set the | ||
| equivalent environment variable value in your application. |
There was a problem hiding this comment.
Question
Set it to what? I am assuming it is the full path to the credential file, but think it would be helpful to specify this for the reader.
| equivalent environment variable value in your application. | ||
| - Create an AWS profile for your MongoDB credentials and set the | ||
| ``AWS_PROFILE`` environment variable to that profile name. | ||
|
|
There was a problem hiding this comment.
Question
What if you do both of these options? Which one has precedence? Might be beyond the scope or not something you can answer, but was a thought that came to mind.
There was a problem hiding this comment.
Yes, it might be out of scope. I'm not sure what the order is
source/whats-new.txt
Outdated
|
|
||
| Mutually Recursive Schema Type Checking | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| This release also includes added support for **mutually |
There was a problem hiding this comment.
Suggestion
Given how you've restructured this beginning, the "also" here seems out of place and that it doesn't flow well.
Suggested change
| This release also includes added support for **mutually | |
| This release includes added support for **mutually |
rustagir
added a commit
that referenced
this pull request
May 19, 2023
* DOCSP-26403: changes to aws credential retrieval * formatting fixes * capitalization * DB PR fixes 1 (cherry picked from commit 5bcdb61)
rustagir
added a commit
that referenced
this pull request
May 19, 2023
* DOCSP-26403: changes to aws credential retrieval * formatting fixes * capitalization * DB PR fixes 1 (cherry picked from commit 5bcdb61)
rustagir
added a commit
that referenced
this pull request
May 19, 2023
* DOCSP-26403: changes to aws credential retrieval * formatting fixes * capitalization * DB PR fixes 1 (cherry picked from commit 5bcdb61)
rustagir
added a commit
that referenced
this pull request
May 19, 2023
* DOCSP-26403: changes to aws credential retrieval * formatting fixes * capitalization * DB PR fixes 1 (cherry picked from commit 5bcdb61)
rustagir
added a commit
that referenced
this pull request
May 19, 2023
* DOCSP-26403: changes to aws credential retrieval * formatting fixes * capitalization * DB PR fixes 1 (cherry picked from commit 5bcdb61)
rustagir
added a commit
that referenced
this pull request
May 19, 2023
* DOCSP-26403: changes to aws credential retrieval * formatting fixes * capitalization * DB PR fixes 1 (cherry picked from commit 5bcdb61)
rustagir
added a commit
that referenced
this pull request
May 19, 2023
rustagir
added a commit
that referenced
this pull request
May 19, 2023
mongoKart
pushed a commit
to mongoKart/docs-node
that referenced
this pull request
Nov 3, 2023
* DOCSP-26403: changes to aws credential retrieval * formatting fixes * capitalization * DB PR fixes 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - DOCSP-26403
Staging:
Self-Review Checklist