Skip to content

DOCSP-30327: Added clear link for downloading and installing the driver #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

DBirtolo-mdb
Copy link
Contributor

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-30327
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/node/docsworker-xlarge/DOCSP-30327/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?

Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small change then LGTM

source/index.txt Outdated
@@ -28,7 +28,10 @@ Introduction
Welcome to the documentation site for the official {+driver-long+}.
You can add the driver to your application to work with MongoDB
in JavaScript. Download it using `npm <https://www.npmjs.com/>`__
or set up a runnable project by following our Quick Start guide.
or set up a runnable project by following our Quick Start guide. For more
information on downloading and installing the {+driver-short+}, see
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I: about vs. on

S:

Suggested change
information on downloading and installing the {+driver-short+}, see
information about downloading and installing the {+driver-short+}, see

(BTW, I disagree with the style guide on this point; "on" just sounds better here.)

source/index.txt Outdated
Comment on lines 30 to 31
in JavaScript. Download it using `npm <https://www.npmjs.com/>`__
or set up a runnable project by following our Quick Start guide.
or set up a runnable project by following our Quick Start guide. For more
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:

"... work with MongoDB in JavaScript or TypeScript."

Omit the next sentence about "Download" or "Set up a Runnable project" since the next sentence provides that information and the npm link is misleading.

@DBirtolo-mdb DBirtolo-mdb merged commit 9d10b97 into mongodb:master Jun 13, 2023
@DBirtolo-mdb DBirtolo-mdb deleted the DOCSP-30327 branch June 13, 2023 20:34
DBirtolo-mdb added a commit that referenced this pull request Jun 13, 2023
…er (#703)

* DOCSP-30327: Added clear link for downloading and installing the driver.

* PR feedback.

(cherry picked from commit 9d10b97)
DBirtolo-mdb added a commit that referenced this pull request Jun 13, 2023
…er (#703)

* DOCSP-30327: Added clear link for downloading and installing the driver.

* PR feedback.

(cherry picked from commit 9d10b97)
DBirtolo-mdb added a commit that referenced this pull request Jun 13, 2023
…er (#703)

* DOCSP-30327: Added clear link for downloading and installing the driver.

* PR feedback.

(cherry picked from commit 9d10b97)
DBirtolo-mdb added a commit that referenced this pull request Jun 13, 2023
…er (#703)

* DOCSP-30327: Added clear link for downloading and installing the driver.

* PR feedback.

(cherry picked from commit 9d10b97)
DBirtolo-mdb added a commit that referenced this pull request Jun 13, 2023
…er (#703)

* DOCSP-30327: Added clear link for downloading and installing the driver.

* PR feedback.

(cherry picked from commit 9d10b97)
DBirtolo-mdb added a commit that referenced this pull request Jun 13, 2023
…er (#703)

* DOCSP-30327: Added clear link for downloading and installing the driver.

* PR feedback.

(cherry picked from commit 9d10b97)
DBirtolo-mdb added a commit that referenced this pull request Jun 13, 2023
…er (#703)

* DOCSP-30327: Added clear link for downloading and installing the driver.

* PR feedback.

(cherry picked from commit 9d10b97)
DBirtolo-mdb added a commit that referenced this pull request Jun 13, 2023
…er (#703)

* DOCSP-30327: Added clear link for downloading and installing the driver.

* PR feedback.

(cherry picked from commit 9d10b97)
DBirtolo-mdb added a commit that referenced this pull request Jun 13, 2023
…er (#703)

* DOCSP-30327: Added clear link for downloading and installing the driver.

* PR feedback.

(cherry picked from commit 9d10b97)
DBirtolo-mdb added a commit that referenced this pull request Jun 13, 2023
…er (#703)

* DOCSP-30327: Added clear link for downloading and installing the driver.

* PR feedback.

(cherry picked from commit 9d10b97)
DBirtolo-mdb added a commit that referenced this pull request Jun 13, 2023
…er (#703)

* DOCSP-30327: Added clear link for downloading and installing the driver.

* PR feedback.

(cherry picked from commit 9d10b97)
DBirtolo-mdb added a commit that referenced this pull request Jun 13, 2023
…er (#703)

* DOCSP-30327: Added clear link for downloading and installing the driver.

* PR feedback.

(cherry picked from commit 9d10b97)
DBirtolo-mdb added a commit that referenced this pull request Jun 13, 2023
…er (#703)

* DOCSP-30327: Added clear link for downloading and installing the driver.

* PR feedback.

(cherry picked from commit 9d10b97)
DBirtolo-mdb added a commit that referenced this pull request Jun 13, 2023
…er (#703)

* DOCSP-30327: Added clear link for downloading and installing the driver.

* PR feedback.

(cherry picked from commit 9d10b97)
DBirtolo-mdb added a commit that referenced this pull request Jun 13, 2023
…er (#703)

* DOCSP-30327: Added clear link for downloading and installing the driver.

* PR feedback.

(cherry picked from commit 9d10b97)
DBirtolo-mdb added a commit that referenced this pull request Jun 13, 2023
…er (#703)

* DOCSP-30327: Added clear link for downloading and installing the driver.

* PR feedback.

(cherry picked from commit 9d10b97)
DBirtolo-mdb added a commit that referenced this pull request Jun 13, 2023
…er (#703)

* DOCSP-30327: Added clear link for downloading and installing the driver.

* PR feedback.

(cherry picked from commit 9d10b97)
DBirtolo-mdb added a commit that referenced this pull request Jun 13, 2023
…er (#703)

* DOCSP-30327: Added clear link for downloading and installing the driver.

* PR feedback.

(cherry picked from commit 9d10b97)
DBirtolo-mdb added a commit that referenced this pull request Jun 13, 2023
…er (#703)

* DOCSP-30327: Added clear link for downloading and installing the driver.

* PR feedback.

(cherry picked from commit 9d10b97)
DBirtolo-mdb added a commit that referenced this pull request Jun 13, 2023
…er (#703)

* DOCSP-30327: Added clear link for downloading and installing the driver.

* PR feedback.

(cherry picked from commit 9d10b97)
mongoKart pushed a commit to mongoKart/docs-node that referenced this pull request Nov 3, 2023
…er (mongodb#703)

* DOCSP-30327: Added clear link for downloading and installing the driver.

* PR feedback.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants