DOCSP-32718: add CodeWhisperer comments to collation code snippets #763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustagir
approved these changes
Aug 31, 2023
| @@ -1,3 +1,4 @@ | |||
| // Retrieve the total matching names, grouped by the first_name field and sorted by using the German phonebook collation | |||
There was a problem hiding this comment.
S: since this comment is causing horizontal scroll, make it a multi line comment. Or, could it be more beneficial to comment before the each stage + the collation line?
| @@ -1,15 +1,20 @@ | |||
| // start create collection with collation | |||
| // Create the collection with a collation | |||
| // Create the "souvenirs" collection and specify the French Canadian collation. | |||
There was a problem hiding this comment.
S: no periods for single line comments
Comment on lines
12
to
17
| // no collation specified | ||
| /* | ||
| Retrieve documents that match the "year" value "1980" | ||
| in descending order of the value of the "title" field | ||
| that does not use the collation index. | ||
| */ |
There was a problem hiding this comment.
Q: For this code comment and the next, is there a way to combine the code comments content so these aren't stacked?
added 5 commits
August 31, 2023 18:14
ccho-mongodb
force-pushed
the
DOCSP-32718-collation-snippets
branch
from
fff87d6 to
2c35024
Compare
ccho-mongodb
pushed a commit
that referenced
this pull request
Sep 8, 2023
) * DOCSP-32718: add CodeWhisperer comments to collation code snippets (cherry picked from commit c66ae08)
mongoKart
pushed a commit
to mongoKart/docs-node
that referenced
this pull request
Nov 3, 2023
…ongodb#763) * DOCSP-32718: add CodeWhisperer comments to collation code snippets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-32718
Staging -
https://docs-mongodbcom-staging.corp.mongodb.com/node/docsworker-xlarge/DOCSP-32718-collation-snippets/fundamentals/collations/
Self-Review Checklist