-
Notifications
You must be signed in to change notification settings - Fork 52
DOCPS-31571: Add upgrade information #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCPS-31571: Add upgrade information #779
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. Requested a formatting change and slight modification in how the content is presented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added a couple sentences that I think could be helpful to incorporate.
source/upgrade.txt
Outdated
|
||
npm install mongodb@{+version+} | ||
|
||
To upgrade to a different version of the driver, replace ``{+version+}`` with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion:
Rather than depending on the user to identify a specific "version", I think it could be easier to follow by explaining the placement of the information.
E.g.
To upgrade to a different version of the driver, replace the information after the "@" symbol with your preferred version number.
It could also be helpful to link to the official npm documentation as well. E.g.
To learn more about the npm install command, see the `npm-install <https://docs.npmjs.com/cli/v10/commands/npm-install?v=true>`__ npm documentation.
source/upgrade.txt
Outdated
functionality. | ||
On this page, you can learn how to upgrade your driver to a new version. This page also | ||
includes the changes you must make to your application to upgrade your driver | ||
without a loss of functionality, if applicable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion:
I think "a loss of functionality" doesn't identify what loses the functionality as well as the following phrase:
without a loss of functionality, if applicable. | |
without losing functionality, if applicable. |
Implied in this statement is "without your application losing functionality" whereas the current version doesn't imply that relationship.
* DOCPS-31571: Add upgrade information * small changes * wording * feedback fixes * vale fix * adding clarifying info (cherry picked from commit 31ac73b)
* DOCPS-31571: Add upgrade information * small changes * wording * feedback fixes * vale fix * adding clarifying info (cherry picked from commit 31ac73b)
* DOCPS-31571: Add upgrade information * small changes * wording * feedback fixes * vale fix * adding clarifying info (cherry picked from commit 31ac73b)
* DOCPS-31571: Add upgrade information * small changes * wording * feedback fixes * vale fix * adding clarifying info (cherry picked from commit 31ac73b)
* DOCPS-31571: Add upgrade information * small changes * wording * feedback fixes * vale fix * adding clarifying info (cherry picked from commit 31ac73b)
* DOCPS-31571: Add upgrade information * small changes * wording * feedback fixes * vale fix * adding clarifying info (cherry picked from commit 31ac73b)
* DOCPS-31571: Add upgrade information * small changes * wording * feedback fixes * vale fix * adding clarifying info (cherry picked from commit 31ac73b)
* DOCPS-31571: Add upgrade information * small changes * wording * feedback fixes * vale fix * adding clarifying info (cherry picked from commit 31ac73b)
* DOCPS-31571: Add upgrade information * small changes * wording * feedback fixes * vale fix * adding clarifying info (cherry picked from commit 31ac73b)
* DOCPS-31571: Add upgrade information * small changes * wording * feedback fixes * vale fix * adding clarifying info (cherry picked from commit 31ac73b)
* DOCPS-31571: Add upgrade information * small changes * wording * feedback fixes * vale fix * adding clarifying info (cherry picked from commit 31ac73b)
* DOCPS-31571: Add upgrade information * small changes * wording * feedback fixes * vale fix * adding clarifying info (cherry picked from commit 31ac73b)
* DOCPS-31571: Add upgrade information * small changes * wording * feedback fixes * vale fix * adding clarifying info (cherry picked from commit 31ac73b)
* DOCPS-31571: Add upgrade information * small changes * wording * feedback fixes * vale fix * adding clarifying info (cherry picked from commit 31ac73b)
* DOCPS-31571: Add upgrade information * small changes * wording * feedback fixes * vale fix * adding clarifying info (cherry picked from commit 31ac73b)
* DOCPS-31571: Add upgrade information * small changes * wording * feedback fixes * vale fix * adding clarifying info (cherry picked from commit 31ac73b)
* DOCPS-31571: Add upgrade information * small changes * wording * feedback fixes * vale fix * adding clarifying info (cherry picked from commit 31ac73b)
* DOCPS-31571: Add upgrade information * small changes * wording * feedback fixes * vale fix * adding clarifying info (cherry picked from commit 31ac73b)
* DOCPS-31571: Add upgrade information * small changes * wording * feedback fixes * vale fix * adding clarifying info (cherry picked from commit 31ac73b)
* DOCPS-31571: Add upgrade information * small changes * wording * feedback fixes * vale fix * adding clarifying info (cherry picked from commit 31ac73b)
* DOCPS-31571: Add upgrade information * small changes * wording * feedback fixes * vale fix * adding clarifying info
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-31571
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/node/docsworker-xlarge/DOCPS-31571-upgrade-instructions/upgrade/
Self-Review Checklist