Skip to content

DOCSP-33118: broken link in index #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

rustagir
Copy link
Collaborator

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-33118
Staging - https://preview-mongodbrustagir.gatsbyjs.io/node/DOCSP-33118-broken-link/#introduction

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?

Copy link
Contributor

@ccho-mongodb ccho-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identified an issue, but approving since I think the changes are straightforward.

source/index.txt Outdated
Comment on lines 32 to 33
installing the {+driver-short+}, see the
:ref:`Install Node and npm <node-quickstart-install-node>` section of the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue:
The sentence describes the link as "information about download and installing the driver", but links to a section that explains how to install Node.js and npm.

Suggestion:

I think linking to "Add MongoDB as a Dependency" would more closely match the descriptive text. Alternatively, change the descriptive text to match the content of the link.

@rustagir rustagir merged commit 2c69f80 into mongodb:v5.0 Sep 15, 2023
rustagir added a commit that referenced this pull request Sep 15, 2023
* DOCSP-33118: broken link in index

* save fix

* build fix

* CC suggestion

(cherry picked from commit 2c69f80)
rustagir added a commit that referenced this pull request Sep 15, 2023
* DOCSP-33118: broken link in index

* save fix

* build fix

* CC suggestion

(cherry picked from commit 2c69f80)
(cherry picked from commit 2d18155)
rustagir added a commit that referenced this pull request Sep 15, 2023
* DOCSP-33118: broken link in index

* save fix

* build fix

* CC suggestion

(cherry picked from commit 2c69f80)
(cherry picked from commit 2d18155)
rustagir added a commit that referenced this pull request Sep 15, 2023
* DOCSP-33118: broken link in index

* save fix

* build fix

* CC suggestion

(cherry picked from commit 2c69f80)
(cherry picked from commit 2d18155)
(cherry picked from commit b23427d)
rustagir added a commit that referenced this pull request Sep 15, 2023
* DOCSP-33118: broken link in index

* save fix

* build fix

* CC suggestion

(cherry picked from commit 2c69f80)
(cherry picked from commit 2d18155)
(cherry picked from commit b23427d)
rustagir added a commit that referenced this pull request Sep 15, 2023
* DOCSP-33118: broken link in index

* save fix

* build fix

* CC suggestion

(cherry picked from commit 2c69f80)
(cherry picked from commit 2d18155)
(cherry picked from commit b23427d)
rustagir added a commit that referenced this pull request Sep 15, 2023
* DOCSP-33118: broken link in index

* save fix

* build fix

* CC suggestion

(cherry picked from commit 2c69f80)
(cherry picked from commit 2d18155)
(cherry picked from commit b23427d)
rustagir added a commit that referenced this pull request Sep 15, 2023
* DOCSP-33118: broken link in index

* save fix

* build fix

* CC suggestion

(cherry picked from commit 2c69f80)
(cherry picked from commit 2d18155)
(cherry picked from commit b23427d)
rustagir added a commit that referenced this pull request Sep 15, 2023
* DOCSP-33118: broken link in index

* save fix

* build fix

* CC suggestion

(cherry picked from commit 2c69f80)
(cherry picked from commit 2d18155)
(cherry picked from commit b23427d)
rustagir added a commit that referenced this pull request Sep 15, 2023
* DOCSP-33118: broken link in index

* save fix

* build fix

* CC suggestion

(cherry picked from commit 2c69f80)
(cherry picked from commit 2d18155)
(cherry picked from commit b23427d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants