DOCSP-32752 Support for setting AWS region #958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rachel-mack
requested changes
Feb 5, 2025
| @@ -234,6 +234,23 @@ The driver checks for your credentials in the following sources in order: | |||
| .. literalinclude:: /code-snippets/authentication/aws-env-variable.js | |||
| :language: javascript | |||
|
|
|||
| .. note:: How to Set the AWS Region for Regional Endpoints | |||
There was a problem hiding this comment.
I would move this to line 230 and not make it a note. I would also include a code block:
export AWS_STS_REGIONAL_ENDPOINTS=regional //enable regional endpoints
export AWS_REGION=us-east-2 //select your AWS regionLooking at the JIRA ticket, it looks like we should specify that the default region is us-east-1.
There was a problem hiding this comment.
The restructuring makes sense, thanks! Before you take another look, I'll ask the technical reviewer to confirm the default region and whether global endpoints are available for this feature (in which case I would delete the first sentence about why to use regional endpoints).
|
For the technical reviewer, can you confirm the following:
|
nbbeeken
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
the warning LGTM!
Yes us-east-1 is the default if neither are set.
Auth does not always use your region's endpoint (then us-east-1 would not be the default, your current region would be). So the first sentence should be kept because it is an improvement to enable this :) ty again
rachel-mack
approved these changes
Feb 6, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Feb 25, 2025
* DOCSP-32752 Suppor for setting AWS region * edits * merge * another merge attempt * edit * edit on title * RM review * update links * default region * tech review note * change wanring msg * wording changed * change link (cherry picked from commit 65f4f5c)
github-actions bot
pushed a commit
that referenced
this pull request
Feb 25, 2025
* DOCSP-32752 Suppor for setting AWS region * edits * merge * another merge attempt * edit * edit on title * RM review * update links * default region * tech review note * change wanring msg * wording changed * change link (cherry picked from commit 65f4f5c)
github-actions bot
pushed a commit
that referenced
this pull request
Feb 25, 2025
* DOCSP-32752 Suppor for setting AWS region * edits * merge * another merge attempt * edit * edit on title * RM review * update links * default region * tech review note * change wanring msg * wording changed * change link (cherry picked from commit 65f4f5c)
github-actions bot
pushed a commit
that referenced
this pull request
Feb 25, 2025
* DOCSP-32752 Suppor for setting AWS region * edits * merge * another merge attempt * edit * edit on title * RM review * update links * default region * tech review note * change wanring msg * wording changed * change link (cherry picked from commit 65f4f5c)
This was referenced Feb 25, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Feb 25, 2025
* DOCSP-32752 Suppor for setting AWS region * edits * merge * another merge attempt * edit * edit on title * RM review * update links * default region * tech review note * change wanring msg * wording changed * change link (cherry picked from commit 65f4f5c)
github-actions bot
pushed a commit
that referenced
this pull request
Feb 25, 2025
* DOCSP-32752 Suppor for setting AWS region * edits * merge * another merge attempt * edit * edit on title * RM review * update links * default region * tech review note * change wanring msg * wording changed * change link (cherry picked from commit 65f4f5c)
This was referenced Feb 25, 2025
lindseymoore
added a commit
that referenced
this pull request
Feb 25, 2025
* DOCSP-32752 Suppor for setting AWS region * edits * merge * another merge attempt * edit * edit on title * RM review * update links * default region * tech review note * change wanring msg * wording changed * change link (cherry picked from commit 65f4f5c) Co-authored-by: lindseymoore <[email protected]>
lindseymoore
added a commit
that referenced
this pull request
Feb 25, 2025
* DOCSP-32752 Suppor for setting AWS region * edits * merge * another merge attempt * edit * edit on title * RM review * update links * default region * tech review note * change wanring msg * wording changed * change link (cherry picked from commit 65f4f5c) Co-authored-by: lindseymoore <[email protected]>
lindseymoore
added a commit
that referenced
this pull request
Feb 25, 2025
* DOCSP-32752 Suppor for setting AWS region * edits * merge * another merge attempt * edit * edit on title * RM review * update links * default region * tech review note * change wanring msg * wording changed * change link (cherry picked from commit 65f4f5c) Co-authored-by: lindseymoore <[email protected]>
lindseymoore
added a commit
that referenced
this pull request
Feb 25, 2025
* DOCSP-32752 Suppor for setting AWS region * edits * merge * another merge attempt * edit * edit on title * RM review * update links * default region * tech review note * change wanring msg * wording changed * change link (cherry picked from commit 65f4f5c) Co-authored-by: lindseymoore <[email protected]>
lindseymoore
added a commit
that referenced
this pull request
Feb 25, 2025
* DOCSP-32752 Suppor for setting AWS region * edits * merge * another merge attempt * edit * edit on title * RM review * update links * default region * tech review note * change wanring msg * wording changed * change link (cherry picked from commit 65f4f5c) Co-authored-by: lindseymoore <[email protected]>
lindseymoore
added a commit
that referenced
this pull request
Feb 25, 2025
* DOCSP-32752 Suppor for setting AWS region * edits * merge * another merge attempt * edit * edit on title * RM review * update links * default region * tech review note * change wanring msg * wording changed * change link (cherry picked from commit 65f4f5c) Co-authored-by: lindseymoore <[email protected]>
lindseymoore
added a commit
that referenced
this pull request
Feb 25, 2025
* DOCSP-32752 Suppor for setting AWS region * edits * merge * another merge attempt * edit * edit on title * RM review * update links * default region * tech review note * change wanring msg * wording changed * change link (cherry picked from commit 65f4f5c) Co-authored-by: lindseymoore <[email protected]>
lindseymoore
added a commit
that referenced
this pull request
Feb 25, 2025
* DOCSP-32752 Suppor for setting AWS region * edits * merge * another merge attempt * edit * edit on title * RM review * update links * default region * tech review note * change wanring msg * wording changed * change link (cherry picked from commit 65f4f5c) Co-authored-by: lindseymoore <[email protected]>
lindseymoore
added a commit
that referenced
this pull request
Feb 25, 2025
* DOCSP-32752 Suppor for setting AWS region * edits * merge * another merge attempt * edit * edit on title * RM review * update links * default region * tech review note * change wanring msg * wording changed * change link (cherry picked from commit 65f4f5c) Co-authored-by: lindseymoore <[email protected]>
lindseymoore
added a commit
that referenced
this pull request
Feb 25, 2025
* DOCSP-32752 Suppor for setting AWS region * edits * merge * another merge attempt * edit * edit on title * RM review * update links * default region * tech review note * change wanring msg * wording changed * change link (cherry picked from commit 65f4f5c) Co-authored-by: lindseymoore <[email protected]>
lindseymoore
added a commit
that referenced
this pull request
Feb 25, 2025
* DOCSP-32752 Suppor for setting AWS region * edits * merge * another merge attempt * edit * edit on title * RM review * update links * default region * tech review note * change wanring msg * wording changed * change link (cherry picked from commit 65f4f5c) Co-authored-by: lindseymoore <[email protected]>
lindseymoore
added a commit
that referenced
this pull request
Feb 25, 2025
* DOCSP-32752 Suppor for setting AWS region * edits * merge * another merge attempt * edit * edit on title * RM review * update links * default region * tech review note * change wanring msg * wording changed * change link (cherry picked from commit 65f4f5c) Co-authored-by: lindseymoore <[email protected]>
lindseymoore
added a commit
that referenced
this pull request
Feb 25, 2025
* DOCSP-32752 Suppor for setting AWS region * edits * merge * another merge attempt * edit * edit on title * RM review * update links * default region * tech review note * change wanring msg * wording changed * change link (cherry picked from commit 65f4f5c) Co-authored-by: lindseymoore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-32752
Staging - https://deploy-preview-958--docs-node.netlify.app/fundamentals/authentication/mechanisms/#mongodb-aws
(Note in the Web Identity Token tab)
Self-Review Checklist