DOCSP-44644: db/coll access methods #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-php-library ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rachel-mack
requested changes
Feb 4, 2025
Comment on lines
32
to
36
| ``$databaseName`` : string | ||
| The name of the database containing the collection to select. | ||
|
|
||
| ``$collectionName`` : string | ||
| The name of the collection to select. |
There was a problem hiding this comment.
Maybe just semantics:
Suggested change
| ``$databaseName`` : string | |
| The name of the database containing the collection to select. | |
| ``$collectionName`` : string | |
| The name of the collection to select. | |
| ``$databaseName`` : string | |
| The name of the database containing the collection to get. | |
| ``$collectionName`` : string | |
| The name of the collection to get. |
There was a problem hiding this comment.
I'll just change this wording to "access". I think get is too general and might not accurately describe what is happening, despite the methods' names
Comment on lines
44
to
62
| * - readConcern | ||
| - :php:`MongoDB\Driver\ReadConcern <class.mongodb-driver-readconcern>` | ||
| - The default read concern to use for database operations. Defaults to | ||
| the client's read concern. | ||
|
|
||
| * - readPreference | ||
| - :php:`MongoDB\Driver\ReadPreference <class.mongodb-driver-readpreference>` | ||
| - The default read preference to use for database operations. Defaults to | ||
| the client's read preference. | ||
|
|
||
| * - typeMap | ||
| - array | ||
| - The default type map to use for database operations. Defaults to the | ||
| client's type map. | ||
|
|
||
| * - writeConcern | ||
| - :php:`MongoDB\Driver\WriteConcern <class.mongodb-driver-writeconcern>` | ||
| - The default write concern to use for database operations. Defaults to | ||
| the client's write concern. |
There was a problem hiding this comment.
This indentation is causing the top line to be bolded. This should be updated on the selectDatabase() page as well.
Suggested change
| * - readConcern | |
| - :php:`MongoDB\Driver\ReadConcern <class.mongodb-driver-readconcern>` | |
| - The default read concern to use for database operations. Defaults to | |
| the client's read concern. | |
| * - readPreference | |
| - :php:`MongoDB\Driver\ReadPreference <class.mongodb-driver-readpreference>` | |
| - The default read preference to use for database operations. Defaults to | |
| the client's read preference. | |
| * - typeMap | |
| - array | |
| - The default type map to use for database operations. Defaults to the | |
| client's type map. | |
| * - writeConcern | |
| - :php:`MongoDB\Driver\WriteConcern <class.mongodb-driver-writeconcern>` | |
| - The default write concern to use for database operations. Defaults to | |
| the client's write concern. | |
| * - readConcern | |
| - :php:`MongoDB\Driver\ReadConcern <class.mongodb-driver-readconcern>` | |
| - The default read concern to use for database operations. Defaults to | |
| the client's read concern. | |
| * - readPreference | |
| - :php:`MongoDB\Driver\ReadPreference <class.mongodb-driver-readpreference>` | |
| - The default read preference to use for database operations. Defaults to | |
| the client's read preference. | |
| * - typeMap | |
| - array | |
| - The default type map to use for database operations. Defaults to the | |
| client's type map. | |
| * - writeConcern | |
| - :php:`MongoDB\Driver\WriteConcern <class.mongodb-driver-writeconcern>` | |
| - The default write concern to use for database operations. Defaults to | |
| the client's write concern. |
There was a problem hiding this comment.
this is a vscode issue, just resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-44644
Staging:
new method pages:
DB getcoll
client getdb
client getcoll
whats new
Self-Review Checklist