Remove migrations-php.yaml in favor of copying entire directory #3
Conversation
| @@ -18,6 +18,12 @@ help: | |||
| @echo 'Variables' | |||
| @echo ' ARGS - Arguments to pass to mut-publish' | |||
|
|
|||
| html: | |||
There was a problem hiding this comment.
This approach was suggested by @i80and, but I imagine it needs better integration with the actual deploy make targets below.
| rm -r source/ | ||
| mkdir source | ||
| cp -a build/php-library/docs/* source | ||
| giza make html |
| html: | ||
| rm -r source/ | ||
| mkdir source | ||
| cp -a build/php-library/docs/* source |
There was a problem hiding this comment.
@i80and suggests using rsync --delete here instead of the rm, mkdir, cp bits.
jmikola
force-pushed
the
remove-migrations
branch
from
6377f3d to
4f60086
Compare
| @@ -18,6 +18,10 @@ help: | |||
| @echo 'Variables' | |||
| @echo ' ARGS - Arguments to pass to mut-publish' | |||
|
|
|||
| publish: | |||
| rsync -a --delete build/php-library/docs/ source/ | |||
There was a problem hiding this comment.
Ruhroh. If you start from an empty build directory, this errors out:
~/docs-php-library(master) $make publish
rsync -a --delete build/php-library/docs/ source/
rsync: link_stat "/Users/allison/docs-php-library/build/php-library/docs/." failed: No such file or directory (2)
rsync error: some files could not be transferred (code 23) at /BuildRoot/Library/Caches/com.apple.xbs/Sources/rsync/rsync-47/rsync/main.c(992) [sender=2.6.9]
It seems to be attempting to run before the PHP Library repo is cloned to build/php-library/… Thoughts @i80and?
There was a problem hiding this comment.
Ehhhhh shoot I should have expected that. How do you folks feel about using git submodules instead of giza's assets system?
For example, you would run git submodule add -f -b master -- https://github.com/mongodb/mongo-php-library.git build/php-library, and then git submodule update right before the rsync
jmikola
force-pushed
the
remove-migrations
branch
from
4f60086 to
d642ed3
Compare
|
Merged! |
For local builds, this removes the need to manually list each source file in the migrations YAML file, which is bound to have problems once we multiple branches.