Skip to content

Update the Makefile target to add the source/ directory if it doesn't exist already #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

ccho-mongodb
Copy link
Contributor

Need to ensure that the "source/" path exists for the rsync command executed when using one of the make targets that depends on it. If it doesn't exist, the build will fail with an error that looks like the following:

giza make html
INFO:giza.operations.make:running sphinx build operation, equivalent to: giza sphinx --builder html
INFO:giza.content.assets:updated /Users/.../dev/docs-php-library/build/docs-tools repository
rsync: link_stat "/Users/.../dev/docs-php-library/source/." failed: No such file or directory (2)
rsync error: some files could not be transferred (code 23) at /AppleInternal/Library/BuildRoots/a0876c02-1788-11ed-b9c4-96898e02b808/Library/Caches/com.apple.xbs/Sources/rsync/rsync/main.c(996) [sender=2.6.9]
ERROR:giza.content.source:source transfer rsync had error: 23

By adding the "mkdir -p" command, you can ensure that the directory is created or noop if it already exists.

Copy link
Collaborator

@jordan-smith721 jordan-smith721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ccho-mongodb ccho-mongodb merged commit 82844c8 into mongodb:master Nov 29, 2022
@ccho-mongodb ccho-mongodb deleted the make-add-mkdir branch November 29, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants