-
Notifications
You must be signed in to change notification settings - Fork 34
DOP-4884: Inline the mongodb/mongo-php-library docs submodule into this repository #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since ext-mongodb 1.5.0 drops support for server 2.6, we can remove wire version checks and legacy code for servers before 3.0 (i.e. wire version 3).
Note: this does not address using the startAfter option for resuming. That will be implemented in PHPLIB-411 with the introduction of a resume token accessor method and support for postBatchResumeToken.
Merged from #642. https://jira.mongodb.org/browse/PHPLIB-402 I've extracted the `is_in_transaction` helper from `MongoDB\Collection` in a separate to functions since we need it more often. I've also decided to extract the options for the aggregate helper to a common file to avoid unnecessary duplication of option descriptions.
The operation field isn't used for anything in our documentation. This was introduced in 1c75951 and it looks like we missed cleaning it up in later commits that changed every other operation field to null.
* v1.18: (50 commits) Enable auto-merge in merge-up workflow (#1295) PHPLIB-1447: Add SBOM lite (#1292) Fix syntax error in docs (#1285) PHPLIB-1163 Create tutorial for using MongoDB with Bref (#1273) (#1282) Create sarif report when running psalm (#1280) Update composer.json and CI matrices for 1.18.0 PHPLIB-1410: Invoke drivers-evergreen-tools scripts with bash (#1267) PHPLIB-1302: Use Composer\InstalledVersions (#1262) PHPLIB-1320: Support "comment" command option in Collection::createIndex() (#1263) PHPLIB-1413: Use env instead of matrix for driver-version (#1261) Fix Markdown heading PHPLIB-1399: Docs examples for agg expr projection (#1260) PHPLIB-1412: Skip range encryption tests on MongoDB 8.0+ (#1259) PHPLIB-1409: Skip $out and mapReduce tests on serverless (#1254) Exclude read-write-concern tests from serverless testing (#1253) PHPLIB-1409: Convert default write concern tests to unified test format (#1252) PHPLIB-1408: Convert ADL spec test to unified test format (#1250) Remove redundant annotations (#1251) PHPLIB-1404: Convert retryable reads spec tests to unified test format (#1247) DOCSP-36627: Additional double backslash fixes for master (#1246) ...
Co-authored-by: Nora Reidy <[email protected]>
Co-authored-by: Mike Woofter <[email protected]>
* Merge v1.16 into v1.17 (#1327) * PHPLIB-1279: Revise driver/extension terminology (#1335) Prefer "extension" over "driver" when referring to ext-mongodb specifically. Also removes mention of Int64 having a private constructor. * PHPLIB-1466: Remove obsolete "Type Map Limitations" --------- Co-authored-by: Jeremy Mikola <[email protected]>
* Remove usage of deprecated BSON functions * Fix psalm issues * Refactor test
* DOCSP-41495: php v1.20 compat updates * add whats new * edit
jordan-smith721
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inlining the docs content into the content repo simplifies the build process going forward.
The gist of this is that
git filter-repo
was used to prepare mongodb/mongo-php-library:then
git merge
was used to bring those repository commits into this tree:Staged at: https://preview-mongodbi80and.gatsbyjs.io/php-library/DOP-4884/
Build log: https://workerpool-boxgs.mongodbstitch.com/pages/job.html?collName=queue&jobId=66aaa644824f175afd862650
Git History Pudding Proof: