Skip to content

DOCSP-45737: Clarify that users must specify id for bulk inserted docs #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Dec 2, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-45737
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/drivers/docsworker-xlarge/NNNNN/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for docs-pymongo ready!

Name Link
🔨 Latest commit 61907ea
🔍 Latest deploy log https://app.netlify.com/sites/docs-pymongo/deploys/674e3111f811ed000879baa0
😎 Deploy Preview https://deploy-preview-133--docs-pymongo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mcmorisi mcmorisi changed the title DOCSP-45737: Clarify that users must specify id for bulk inserted doc… DOCSP-45737: Clarify that users must specify id for bulk inserted docs Dec 2, 2024
Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w/ a couple suggestions!

Comment on lines 72 to 73
You must specify the ``_id`` field for each document you insert, otherwise the driver
throws a duplicate key error.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion for clarity / avoiding comma splice

Suggested change
You must specify the ``_id`` field for each document you insert, otherwise the driver
throws a duplicate key error.
You must specify a value for the ``_id`` field for each document you insert. If you don't, the driver
throws a duplicate key error.

Comment on lines 72 to 73
You must specify the ``_id`` field for each document you insert, otherwise the driver
throws a duplicate key error.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S:

Suggested change
You must specify the ``_id`` field for each document you insert, otherwise the driver
throws a duplicate key error.
You must specify the ``_id`` field for each document you insert, otherwise the driver
throws a ``DuplicateKeyError``.

@mcmorisi mcmorisi merged commit 4cdc57d into mongodb:master Dec 2, 2024
1 check passed
@mcmorisi mcmorisi deleted the DOCSP-45737-duplicate-key branch December 2, 2024 22:13
mcmorisi added a commit that referenced this pull request Dec 2, 2024
mcmorisi added a commit that referenced this pull request Dec 2, 2024
mcmorisi added a commit that referenced this pull request Dec 2, 2024
mcmorisi added a commit that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants