-
Notifications
You must be signed in to change notification settings - Fork 20
DOCSP-45737: Clarify that users must specify id for bulk inserted docs #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-pymongo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm w/ a couple suggestions!
source/write/bulk-write.txt
Outdated
You must specify the ``_id`` field for each document you insert, otherwise the driver | ||
throws a duplicate key error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion for clarity / avoiding comma splice
You must specify the ``_id`` field for each document you insert, otherwise the driver | |
throws a duplicate key error. | |
You must specify a value for the ``_id`` field for each document you insert. If you don't, the driver | |
throws a duplicate key error. |
source/write/bulk-write.txt
Outdated
You must specify the ``_id`` field for each document you insert, otherwise the driver | ||
throws a duplicate key error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S:
You must specify the ``_id`` field for each document you insert, otherwise the driver | |
throws a duplicate key error. | |
You must specify the ``_id`` field for each document you insert, otherwise the driver | |
throws a ``DuplicateKeyError``. |
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-45737
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/drivers/docsworker-xlarge/NNNNN/
Self-Review Checklist