Skip to content

DOCSP-45883 - Parallelism in transactions #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

mongoKart
Copy link
Collaborator

@mongoKart mongoKart commented Dec 17, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-45883
Staging - https://deploy-preview-135--docs-pymongo.netlify.app/write/transactions/#example

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for docs-pymongo ready!

Name Link
🔨 Latest commit 87b6a85
🔍 Latest deploy log https://app.netlify.com/sites/docs-pymongo/deploys/6761e52f6048740008992309
😎 Deploy Preview https://deploy-preview-135--docs-pymongo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mongoKart mongoKart changed the title autobuilder DOCSP-45883 - Parallelism in transactions Dec 17, 2024
methods described in the preceding section to manually manage the transaction lifecycle.
methods described in the preceding section to manually manage the transaction lifecycle.

.. note:: Parallel Operations Not Supported
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add note manually because {+driver-short+} = 'PyMongo'

Copy link
Collaborator

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question, so requesting changes for that!


.. note:: Parallel Operations Not Supported

{+driver-short+} does not support running parallel operations within a single transaction.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: does PyMongo not support bulk operations on multiple namespaces? If so, I'd add that to the admonition and link to the Bulk Write guide

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Versions 4.9+ do, but we haven't documented it yet, so there's nothing to link to. (Could link to the old docs domain, but that seems like it could be confusing for people...?)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay! then I think not linking is fine

@mongoKart mongoKart requested a review from norareidy December 17, 2024 22:59
Copy link
Collaborator

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@caseyclements caseyclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mongoKart mongoKart merged commit 5ea0b78 into mongodb:master Dec 18, 2024
5 checks passed
@mongoKart mongoKart deleted the docsp-45883-parallel-note branch December 18, 2024 17:51
github-actions bot pushed a commit that referenced this pull request Dec 18, 2024
github-actions bot pushed a commit that referenced this pull request Dec 18, 2024
github-actions bot pushed a commit that referenced this pull request Dec 18, 2024
github-actions bot pushed a commit that referenced this pull request Dec 18, 2024
mongoKart added a commit that referenced this pull request Dec 18, 2024
(cherry picked from commit 5ea0b78)

Co-authored-by: Mike Woofter <[email protected]>
mongoKart added a commit that referenced this pull request Dec 18, 2024
(cherry picked from commit 5ea0b78)

Co-authored-by: Mike Woofter <[email protected]>
mongoKart added a commit that referenced this pull request Dec 18, 2024
(cherry picked from commit 5ea0b78)

Co-authored-by: Mike Woofter <[email protected]>
mongoKart added a commit that referenced this pull request Dec 18, 2024
(cherry picked from commit 5ea0b78)

Co-authored-by: Mike Woofter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants