-
Notifications
You must be signed in to change notification settings - Fork 20
DOCSP-46687 - Collation #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-pymongo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm, few small suggestions!
source/databases-collections.txt
Outdated
but with a default collation of ``fr_CA``: | ||
|
||
.. code-block:: python | ||
:emphasize-lines: 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:emphasize-lines: 2 | |
:emphasize-lines: 4 |
@@ -0,0 +1,12 @@ | |||
When you create an index, you can specify a default **collation** for all operations | |||
you perform on the index. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you perform on the index. | |
you perform on fields that are covered by the index. |
cursor = sample_restaurants.restaurants.find({"cuisine": "Italian"}, max_time_ms=10000, | ||
collation=Collation(locale="fr_CA")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: consider moving into the file and including?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll likely do this for all code samples as part of comprehensive coverage; i'll wait until then so know the final organization of code files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with 1 minor nit.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-46687
Staging Links
Self-Review Checklist