Skip to content

DOCSP-46687 - Collation #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 6, 2025
Merged

Conversation

mongoKart
Copy link
Collaborator

@mongoKart mongoKart commented Jan 23, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-46687

Staging Links

  • databases-collections
  • indexes
  • indexes/compound-index
  • indexes/geospatial-index
  • indexes/multikey-index
  • indexes/single-field-index
  • indexes/text-index
  • indexes/unique-index
  • indexes/wildcard-index
  • read/retrieve
  • write/delete
  • write/update
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented Jan 23, 2025

    Deploy Preview for docs-pymongo ready!

    Name Link
    🔨 Latest commit 292ca61
    🔍 Latest deploy log https://app.netlify.com/sites/docs-pymongo/deploys/67a4e19e85735c00085ecf43
    😎 Deploy Preview https://deploy-preview-153--docs-pymongo.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @rustagir rustagir self-requested a review January 27, 2025 18:10
    Copy link
    Collaborator

    @rustagir rustagir left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    overall lgtm, few small suggestions!

    but with a default collation of ``fr_CA``:

    .. code-block:: python
    :emphasize-lines: 2
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    :emphasize-lines: 2
    :emphasize-lines: 4

    @@ -0,0 +1,12 @@
    When you create an index, you can specify a default **collation** for all operations
    you perform on the index.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    you perform on the index.
    you perform on fields that are covered by the index.

    Comment on lines +188 to +189
    cursor = sample_restaurants.restaurants.find({"cuisine": "Italian"}, max_time_ms=10000,
    collation=Collation(locale="fr_CA"))
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S: consider moving into the file and including?

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    we'll likely do this for all code samples as part of comprehensive coverage; i'll wait until then so know the final organization of code files

    Copy link
    Member

    @ShaneHarvey ShaneHarvey left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM with 1 minor nit.

    @mongoKart mongoKart merged commit 22965ed into mongodb:master Feb 6, 2025
    4 of 5 checks passed
    @mongoKart mongoKart deleted the docsp-46687-collations branch February 6, 2025 16:22
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants