Skip to content

DOCSP-46696: Logging page #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 3, 2025
Merged

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Jan 28, 2025

Largely adapted from this page on the readthedocs domain.

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-46696

Staging Links

  • logging
  • index
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented Jan 28, 2025

    Deploy Preview for docs-pymongo ready!

    Name Link
    🔨 Latest commit e034a2e
    🔍 Latest deploy log https://app.netlify.com/sites/docs-pymongo/deploys/679d25737bb1e300089eab19
    😎 Deploy Preview https://deploy-preview-154--docs-pymongo.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link
    Collaborator

    @rachel-mack rachel-mack left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    One suggestion:

    .. code-block:: python

    import os
    os.environ('MONGODB_LOG_MAX_DOCUMENT_LENGTH') = 2000

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    os.environ('MONGODB_LOG_MAX_DOCUMENT_LENGTH') = 2000
    os.environ['MONGODB_LOG_MAX_DOCUMENT_LENGTH'] = "2000"

    Python requires environment variables to all be strings.

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Will also standardize double quotations for strings in next revision.

    @mcmorisi mcmorisi requested a review from NoahStapp January 31, 2025 19:36
    @mcmorisi mcmorisi merged commit 0876f2f into mongodb:master Feb 3, 2025
    6 checks passed
    mcmorisi added a commit that referenced this pull request Feb 3, 2025
    (cherry picked from commit 0876f2f)
    mcmorisi added a commit that referenced this pull request Feb 3, 2025
    (cherry picked from commit 0876f2f)
    mcmorisi added a commit that referenced this pull request Feb 3, 2025
    (cherry picked from commit 0876f2f)
    mcmorisi added a commit that referenced this pull request Feb 3, 2025
    (cherry picked from commit 0876f2f)
    mcmorisi added a commit that referenced this pull request Feb 3, 2025
    (cherry picked from commit 0876f2f)
    mongoKart pushed a commit to mongoKart/docs-pymongo that referenced this pull request Feb 6, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants