-
Notifications
You must be signed in to change notification settings - Fork 20
v4.11 release #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4.11 release #155
Conversation
✅ Deploy Preview for docs-pymongo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm w/ a few small suggestions
source/upgrade.txt
Outdated
now v3.9. | ||
- PyPy v3.9 is no longer supported. The minimum supported PyPy version is now | ||
v3.10. | ||
- The minimum wire version is now 7. For more information, see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s: v7? or 7.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, this was already in here from a previous ticket but I don't see it on the release notes. I'll have this double-checked by the tech reviewer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Users don't understand wire version and we already say v3.6 is no longer supported.
above. I suggest we remove the wire version note.
@@ -19,20 +19,20 @@ Python 3 | |||
- CPython 3.4 | |||
- PyPy3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page says "PyPy3 is a Python 3.2-compatible alternative interpreter" but that's incorrect. PyMongo 4.11 supports PyPy3.10+ which is a Python 3.10-compatible alternative interpreter. The compat table should also be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a ticket to address this separately (as discussed on Slack)
https://jira.mongodb.org/browse/DOCSP-46954
source/upgrade.txt
Outdated
now v3.9. | ||
- PyPy v3.9 is no longer supported. The minimum supported PyPy version is now | ||
v3.10. | ||
- The minimum wire version is now 7. For more information, see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Users don't understand wire version and we already say v3.6 is no longer supported.
above. I suggest we remove the wire version note.
source/upgrade.txt
Outdated
@@ -111,8 +111,14 @@ Version 4.11 Breaking Changes | |||
|
|||
- {+mdb-server+} v3.6 is no longer supported. The minimum supported {+mdb-server+} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also add that support for MongoDB 4.0 is deprecated.
source/upgrade.txt
Outdated
- The minimum wire version is now 7. For more information, see | ||
:manual:`minWireVersion | ||
</reference/command/hello/#mongodb-data-hello.minWireVersion>` in the | ||
{+mdb-server+} manual. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a note that we "Dropped support for the MONGODB-CR authenticate mechanism."
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-46865
Staging Links
Self-Review Checklist