Skip to content

Add django banner to landing page #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jordan-smith721
Copy link
Collaborator

@jordan-smith721 jordan-smith721 commented Feb 3, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-46849

Staging Links

https://deploy-preview-160--docs-pymongo.netlify.app/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for docs-pymongo ready!

Name Link
🔨 Latest commit 0675a9c
🔍 Latest deploy log https://app.netlify.com/sites/docs-pymongo/deploys/67a0e38f9826f3000845ab1c
😎 Deploy Preview https://deploy-preview-160--docs-pymongo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@lindseymoore lindseymoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as this 'Backend' terminology is approved by the TPM rather than using 'Driver', LGTM!

targets = ["index.txt"]
variant = "tip"
value = """
{+django-odm+} is now in Public Preview! \
Copy link

@R-shubham R-shubham Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we say Django-MongoDB-Backend rather than django-odm?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@R-shubham {+django-odm+} is just an rST variable, it renders as "Django MongoDB Backend"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, great!

Copy link

@R-shubham R-shubham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jordan-smith721 jordan-smith721 merged commit 346efa4 into mongodb:master Feb 3, 2025
5 checks passed
@jordan-smith721 jordan-smith721 deleted the DOCSP-46849-django-banner branch February 3, 2025 17:15
jordan-smith721 added a commit that referenced this pull request Feb 3, 2025
mongoKart pushed a commit to mongoKart/docs-pymongo that referenced this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants