-
Notifications
You must be signed in to change notification settings - Fork 20
Add django banner to landing page #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add django banner to landing page #160
Conversation
✅ Deploy Preview for docs-pymongo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as this 'Backend' terminology is approved by the TPM rather than using 'Driver', LGTM!
targets = ["index.txt"] | ||
variant = "tip" | ||
value = """ | ||
{+django-odm+} is now in Public Preview! \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we say Django-MongoDB-Backend rather than django-odm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@R-shubham {+django-odm+} is just an rST variable, it renders as "Django MongoDB Backend"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit 346efa4)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-46849
Staging Links
https://deploy-preview-160--docs-pymongo.netlify.app/
Self-Review Checklist