Skip to content

DOCSP-46695: Add extra info on load balancing to connection targets page #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 5, 2025

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Feb 4, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-46695

Staging Links

  • connect/connection-targets
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented Feb 4, 2025

    Deploy Preview for docs-pymongo ready!

    Name Link
    🔨 Latest commit 1024e00
    🔍 Latest deploy log https://app.netlify.com/sites/docs-pymongo/deploys/67a37e28355e190008c4fa23
    😎 Deploy Preview https://deploy-preview-164--docs-pymongo.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link
    Collaborator

    @lindseymoore lindseymoore left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Made a small revision; let me know what you think!

    @mcmorisi mcmorisi requested a review from lindseymoore February 4, 2025 19:51
    Copy link
    Collaborator

    @lindseymoore lindseymoore left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Great LGTM!

    Copy link

    @NoahStapp NoahStapp left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    One minor clarification suggestion.

    @@ -94,6 +103,11 @@ hosts, including ``host1``:
    uri = "mongodb://host1:27017/?replicaSet=sampleRS"
    client = MongoClient(uri)

    {+driver-short+} evenly load balances operations across deployments that fall within

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    By "deployments that fall within" do you mean deployments that are reachable within the configured localThresholdMS? The current wording is a little unclear.

    @mcmorisi mcmorisi requested a review from NoahStapp February 5, 2025 15:05
    @mcmorisi mcmorisi merged commit ce4843c into mongodb:master Feb 5, 2025
    6 checks passed
    @mcmorisi mcmorisi deleted the DOCSP-46695-load-balancers branch February 5, 2025 15:09
    mcmorisi added a commit that referenced this pull request Feb 5, 2025
    mcmorisi added a commit that referenced this pull request Feb 5, 2025
    mcmorisi added a commit that referenced this pull request Feb 5, 2025
    mcmorisi added a commit that referenced this pull request Feb 5, 2025
    mcmorisi added a commit that referenced this pull request Feb 5, 2025
    mongoKart pushed a commit to mongoKart/docs-pymongo that referenced this pull request Feb 6, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants