-
Notifications
You must be signed in to change notification settings - Fork 20
DOCSP-46695: Add extra info on load balancing to connection targets page #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-pymongo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a small revision; let me know what you think!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor clarification suggestion.
@@ -94,6 +103,11 @@ hosts, including ``host1``: | |||
uri = "mongodb://host1:27017/?replicaSet=sampleRS" | |||
client = MongoClient(uri) | |||
|
|||
{+driver-short+} evenly load balances operations across deployments that fall within |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By "deployments that fall within" do you mean deployments that are reachable within the configured localThresholdMS
? The current wording is a little unclear.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-46695
Staging Links
Self-Review Checklist