-
Notifications
You must be signed in to change notification settings - Fork 20
DOCSP-46701: Serialization #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-pymongo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few comments ❇️
source/serialization.txt
Outdated
Serializing Ordered Documents | ||
----------------------------- | ||
|
||
Because the key-value pairs in {+language+} dictionaries are unordered, the order of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All versions of Python we support use ordered dictionaries where the order of inserted keys determines the order of the dictionary. Is the behavior described here still occurring, or is it an artifact of older Python versions that still had unordered dictionaries?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I grabbed the info from this FAQ page. However, I see that this page was pulled from PyMongo docs, which leads me to believe they haven't been updated in a while.
Should I just remove this section completely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that makes sense. Yeah, that section of the troubleshooting FAQ should be removed for no longer being accurate.
This whole section can be removed, yup!
Custom Classes | ||
-------------- | ||
|
||
To serialize and deserialize custom {+language+} classes, you must implement custom logic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to explicitly call out that serialization and deserialization are required in order to work with custom data classes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was my intention with this sentence, but if you feel it's not clear enough I can make it more explicit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's clear enough.
(cherry picked from commit 8079aa9)
(cherry picked from commit 8079aa9)
(cherry picked from commit 8079aa9)
(cherry picked from commit 8079aa9)
(cherry picked from commit 8079aa9)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-46701
Staging Links
Self-Review Checklist