Skip to content

DOCSP-46694 - Extended JSON #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 12, 2025

Conversation

mongoKart
Copy link
Collaborator

@mongoKart mongoKart commented Feb 10, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-46694

Staging Links

  • data-formats/extended-json
  • data-formats
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented Feb 10, 2025

    Deploy Preview for docs-pymongo ready!

    Name Link
    🔨 Latest commit 79a2ea7
    🔍 Latest deploy log https://app.netlify.com/sites/docs-pymongo/deploys/67acd69cf4b7170008ad4bfc
    😎 Deploy Preview https://deploy-preview-169--docs-pymongo.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link
    Collaborator

    @jordan-smith721 jordan-smith721 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM w/ a couple suggestions. Happy to take another look if needed too


    You can write an Extended JSON string from a list of dictionaries
    by calling the ``bson.json_util.dumps()`` method.
    In this example, we output the Extended JSON in the Relaxed mode format.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Is it expected that a user will know what "Relaxed format" is when reading this, or should we provide a brief description?

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Our other docs have more info on the formats (see the Java page I linked earlier), but I thought it was redundant to the Server manual, so I just went with a link.

    One option is to the move the link higher in the page and make it more visible?

    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Makes sense. Yeah I think making the link more visible and closer to the first mention would be helpful. Maybe linking it inline on first mention (although I know we don't do that often) or just adding a "To learn more about..." somewhere closer

    }}}
    ]'''

    By default, the ``dumps()`` method returns the Extended JSON string in the Relaxed

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    What is the Relaxed format? Would users be reasonably expected to know what that means without prior exposure?

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I tried to keep this page focused on just the PyMongo aspects of it to avoid redundancy with the server docs (linked on this page). That said, both you and the docs reviewer asked whether this page should include background info on the format, which makes me think we should 😃

    @mongoKart mongoKart requested a review from NoahStapp February 12, 2025 17:13
    @mongoKart mongoKart merged commit fe2c41a into mongodb:master Feb 12, 2025
    5 of 6 checks passed
    github-actions bot pushed a commit that referenced this pull request Feb 12, 2025
    Co-authored-by: Jordan Smith <[email protected]>
    (cherry picked from commit fe2c41a)
    github-actions bot pushed a commit that referenced this pull request Feb 12, 2025
    Co-authored-by: Jordan Smith <[email protected]>
    (cherry picked from commit fe2c41a)
    github-actions bot pushed a commit that referenced this pull request Feb 12, 2025
    Co-authored-by: Jordan Smith <[email protected]>
    (cherry picked from commit fe2c41a)
    github-actions bot pushed a commit that referenced this pull request Feb 12, 2025
    Co-authored-by: Jordan Smith <[email protected]>
    (cherry picked from commit fe2c41a)
    github-actions bot pushed a commit that referenced this pull request Feb 12, 2025
    Co-authored-by: Jordan Smith <[email protected]>
    (cherry picked from commit fe2c41a)
    @mongoKart mongoKart deleted the docsp-46694-extended-json branch February 12, 2025 17:33
    mongoKart added a commit that referenced this pull request Feb 12, 2025
    Co-authored-by: Jordan Smith <[email protected]>
    (cherry picked from commit fe2c41a)
    
    Co-authored-by: Mike Woofter <[email protected]>
    mongoKart added a commit that referenced this pull request Feb 12, 2025
    Co-authored-by: Jordan Smith <[email protected]>
    (cherry picked from commit fe2c41a)
    
    Co-authored-by: Mike Woofter <[email protected]>
    mongoKart added a commit that referenced this pull request Feb 12, 2025
    Co-authored-by: Jordan Smith <[email protected]>
    (cherry picked from commit fe2c41a)
    
    Co-authored-by: Mike Woofter <[email protected]>
    mongoKart added a commit that referenced this pull request Feb 12, 2025
    Co-authored-by: Jordan Smith <[email protected]>
    (cherry picked from commit fe2c41a)
    
    Co-authored-by: Mike Woofter <[email protected]>
    mongoKart added a commit that referenced this pull request Feb 12, 2025
    Co-authored-by: Jordan Smith <[email protected]>
    (cherry picked from commit fe2c41a)
    
    Co-authored-by: Mike Woofter <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants