-
Notifications
You must be signed in to change notification settings - Fork 20
DOCSP-46752 Pymongo change duplicate title #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-46752 Pymongo change duplicate title #189
Conversation
✅ Deploy Preview for docs-pymongo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice title change! It's too different, though; we'll need an updated URL + redirect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM w/ 1 fix that's probably my fault
config/redirects
Outdated
@@ -14,3 +14,6 @@ raw: ${prefix}/get-started/download-and-install/ -> ${base}/current/get-started/ | |||
[*-master]: ${prefix}/${version}/security/enterprise-authentication/ -> ${base}/${version}/security/authentication/ | |||
[*-master]: ${prefix}/${version}/faq/ -> ${base}/${version}/ | |||
[*-master]: ${prefix}/${version}/connect/connection-pools/ -> ${base}/${version}/connect/connection-options/#connection-pools | |||
[*-master]: ${prefix}/${version}/faq/#is-pymongo-fork-safe- -> ${base}/${version}/troubleshooting/#forking-a-process-causes-a-deadlock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought I removed this redirect! It can be taken out
[*-master]: ${prefix}/${version}/faq/#is-pymongo-fork-safe- -> ${base}/${version}/troubleshooting/#forking-a-process-causes-a-deadlock |
* change duplicate title pymongo * change url and add redirect * remove redirect (cherry picked from commit 163d65f)
* change duplicate title pymongo * change url and add redirect * remove redirect (cherry picked from commit 163d65f)
* change duplicate title pymongo * change url and add redirect * remove redirect (cherry picked from commit 163d65f)
* change duplicate title pymongo * change url and add redirect * remove redirect (cherry picked from commit 163d65f)
* change duplicate title pymongo * change url and add redirect * remove redirect (cherry picked from commit 163d65f)
* change duplicate title pymongo * change url and add redirect * remove redirect (cherry picked from commit 163d65f) Co-authored-by: shuangela <[email protected]>
* change duplicate title pymongo * change url and add redirect * remove redirect (cherry picked from commit 163d65f) Co-authored-by: shuangela <[email protected]>
* change duplicate title pymongo * change url and add redirect * remove redirect (cherry picked from commit 163d65f) Co-authored-by: shuangela <[email protected]>
* change duplicate title pymongo * change url and add redirect * remove redirect (cherry picked from commit 163d65f) Co-authored-by: shuangela <[email protected]>
* change duplicate title pymongo * change url and add redirect * remove redirect (cherry picked from commit 163d65f) Co-authored-by: shuangela <[email protected]>
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-46752
Staging Links
https://deploy-preview-189--docs-pymongo.netlify.app/get-started/run-sample-query/
Self-Review Checklist