Skip to content

DOCSP-46752 Pymongo change duplicate title #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

shuangela
Copy link
Collaborator

@shuangela shuangela commented Feb 26, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-46752

Staging Links

https://deploy-preview-189--docs-pymongo.netlify.app/get-started/run-sample-query/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for docs-pymongo ready!

Name Link
🔨 Latest commit a904119
🔍 Latest deploy log https://app.netlify.com/sites/docs-pymongo/deploys/67c228382f69400008cfdda8
😎 Deploy Preview https://deploy-preview-189--docs-pymongo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@lindseymoore lindseymoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM!

@shuangela shuangela requested a review from sarahemlin February 26, 2025 22:28
Copy link
Collaborator

@sarahemlin sarahemlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice title change! It's too different, though; we'll need an updated URL + redirect.

Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ 1 fix that's probably my fault

config/redirects Outdated
@@ -14,3 +14,6 @@ raw: ${prefix}/get-started/download-and-install/ -> ${base}/current/get-started/
[*-master]: ${prefix}/${version}/security/enterprise-authentication/ -> ${base}/${version}/security/authentication/
[*-master]: ${prefix}/${version}/faq/ -> ${base}/${version}/
[*-master]: ${prefix}/${version}/connect/connection-pools/ -> ${base}/${version}/connect/connection-options/#connection-pools
[*-master]: ${prefix}/${version}/faq/#is-pymongo-fork-safe- -> ${base}/${version}/troubleshooting/#forking-a-process-causes-a-deadlock
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I removed this redirect! It can be taken out

Suggested change
[*-master]: ${prefix}/${version}/faq/#is-pymongo-fork-safe- -> ${base}/${version}/troubleshooting/#forking-a-process-causes-a-deadlock

@shuangela shuangela merged commit 163d65f into mongodb:master Feb 28, 2025
6 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 28, 2025
* change duplicate title pymongo

* change url and add redirect

* remove redirect

(cherry picked from commit 163d65f)
github-actions bot pushed a commit that referenced this pull request Feb 28, 2025
* change duplicate title pymongo

* change url and add redirect

* remove redirect

(cherry picked from commit 163d65f)
github-actions bot pushed a commit that referenced this pull request Feb 28, 2025
* change duplicate title pymongo

* change url and add redirect

* remove redirect

(cherry picked from commit 163d65f)
github-actions bot pushed a commit that referenced this pull request Feb 28, 2025
* change duplicate title pymongo

* change url and add redirect

* remove redirect

(cherry picked from commit 163d65f)
github-actions bot pushed a commit that referenced this pull request Feb 28, 2025
* change duplicate title pymongo

* change url and add redirect

* remove redirect

(cherry picked from commit 163d65f)
shuangela added a commit that referenced this pull request Feb 28, 2025
* change duplicate title pymongo

* change url and add redirect

* remove redirect

(cherry picked from commit 163d65f)

Co-authored-by: shuangela <[email protected]>
shuangela added a commit that referenced this pull request Feb 28, 2025
* change duplicate title pymongo

* change url and add redirect

* remove redirect

(cherry picked from commit 163d65f)

Co-authored-by: shuangela <[email protected]>
shuangela added a commit that referenced this pull request Feb 28, 2025
* change duplicate title pymongo

* change url and add redirect

* remove redirect

(cherry picked from commit 163d65f)

Co-authored-by: shuangela <[email protected]>
shuangela added a commit that referenced this pull request Feb 28, 2025
* change duplicate title pymongo

* change url and add redirect

* remove redirect

(cherry picked from commit 163d65f)

Co-authored-by: shuangela <[email protected]>
shuangela added a commit that referenced this pull request Feb 28, 2025
* change duplicate title pymongo

* change url and add redirect

* remove redirect

(cherry picked from commit 163d65f)

Co-authored-by: shuangela <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants