Skip to content

(DOCSP-26994): @realm/react-ify 'Define an Asymmetric Object - React Native SDK' #2468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mohammadhunan-dev
Copy link
Contributor

@mohammadhunan-dev mohammadhunan-dev commented Jan 5, 2023

Pull Request Info

Jira

Staged Changes

Reminder Checklist

If your PR modifies the docs, you might need to also update some corresponding
pages. Check if completed or N/A.

  • [N/A] Create Jira ticket for corresponding docs-app-services update(s), if any
  • [N/A] Checked/updated Admin API
  • [N/A] Checked/updated CLI reference

Review Guidelines

REVIEWING.md

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

Readability for Commit Hash: c5cef8b

You can see any previous Readability scores (if they exist) by looking
at the comment's history.

Flesch Reading Ease scores for changed documents:

  • source/sdk/react-native/realm-database/schemas/asymmetric-object: 44.54

The following table can be helpful in assessing the readability score of a document.

Score Difficulty
90-100 Very Easy
80-89 Easy
70-79 Fairly Easy
60-69 Medium
50-59 Fairly Hard
30-49 Hard
0-29 Very Hard

@davidhou17 davidhou17 self-requested a review January 6, 2023 18:17
Copy link
Collaborator

@davidhou17 davidhou17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mohammadhunan-dev mohammadhunan-dev merged commit 61ec9f1 into mongodb:realm-react-guidance Jan 6, 2023
mongodben pushed a commit that referenced this pull request Feb 10, 2023
…Native SDK' (#2468)

## Pull Request Info

### Jira

- https://jira.mongodb.org/browse/DOCSP-26994

### Staged Changes

- [Define an Asymmetric Object - React Native
SDK](https://docs-mongodbcom-staging.corp.mongodb.com/realm/docsworker-xlarge/DOCSP-26994-asymmetric-object/sdk/react-native/realm-database/schemas/asymmetric-object/)

### Reminder Checklist

If your PR modifies the docs, you might need to also update some
corresponding
pages. Check if completed or N/A.

- [N/A] Create Jira ticket for corresponding docs-app-services
update(s), if any
- [N/A] Checked/updated Admin API
- [N/A] Checked/updated CLI reference

### Review Guidelines


[REVIEWING.md](https://github.com/mongodb/docs-realm/blob/master/REVIEWING.md)

Co-authored-by: Mohammad Hunan Chughtai <[email protected]>
Copy link
Collaborator

@takameyer takameyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the note and link at the bottom should be placed higher in this document. This way the "why" for using assymetric sync is presented before the "how". Just my opinion. Otherwise looks good.

mongodben pushed a commit that referenced this pull request Mar 21, 2023
…Native SDK' (#2468)

## Pull Request Info

### Jira

- https://jira.mongodb.org/browse/DOCSP-26994

### Staged Changes

- [Define an Asymmetric Object - React Native
SDK](https://docs-mongodbcom-staging.corp.mongodb.com/realm/docsworker-xlarge/DOCSP-26994-asymmetric-object/sdk/react-native/realm-database/schemas/asymmetric-object/)

### Reminder Checklist

If your PR modifies the docs, you might need to also update some
corresponding
pages. Check if completed or N/A.

- [N/A] Create Jira ticket for corresponding docs-app-services
update(s), if any
- [N/A] Checked/updated Admin API
- [N/A] Checked/updated CLI reference

### Review Guidelines


[REVIEWING.md](https://github.com/mongodb/docs-realm/blob/master/REVIEWING.md)

Co-authored-by: Mohammad Hunan Chughtai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants