Skip to content

(DOCSP-27748): Fix broken realm-web tests #2638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

mongodben
Copy link
Collaborator

Pull Request Info

Fix broken realm-web tests. made tests work with existing App Services App in bushicorp org.

Jira

Staged Changes

n/a

Reminder Checklist

If your PR modifies the docs, you might need to also update some corresponding
pages. Check if completed or N/A.

  • Create Jira ticket for corresponding docs-app-services update(s), if any
  • Checked/updated Admin API
  • Checked/updated CLI reference

Review Guidelines

REVIEWING.md

Copy link
Collaborator

@nlarew nlarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass for me so LGTM. Optionally, can we remove all the console.logs in our test files? They can be useful if the test fails but are noisy when everything passes.

@mongodben
Copy link
Collaborator Author

mongodben commented Mar 1, 2023

Optionally, can we remove all the console.logs in our test files? They can be useful if the test fails but are noisy when everything passes.

i'm open to it. or at least only logging when it's really relevant to the code example.

and even then the logs can be disabled in jest to prevent noise.

w/o looking more, not sure what best approach is here. but will explore.

@mongodben mongodben merged commit 4755f18 into mongodb:master Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants