(DOCSP-27598): Clean up web auth examples #2640
Conversation
mongodben
changed the title
source/examples/generated/web/authentication-log-in-and-out.test.snippet.builtin-apple-oauth.js
Show resolved
Hide resolved
|
|
||
| // The logIn() promise will not resolve until you call `handleAuthRedirect()` | ||
| // from the new window after the user has successfully authenticated. | ||
| console.log(`Logged in with id: ${user.id}`); |
There was a problem hiding this comment.
Can we split this into two code snippets? It's not totally clear to the skimmer that handleAuthRedirect() happens in another window / URL. Similar comment for the other OAuth providers.
Also, we have the same codeblock for Facebook but an entirely different format for Google. Should we unify these?
There was a problem hiding this comment.
i thought about doing that in the first pass but didn't b/c of fact it was pretty outside scope of original ticket + some laziness. but we already got outside the scope of the ticket so might as well go for it.
There was a problem hiding this comment.
and in the spirit of scope creep, i think i'll just throw in https://jira.mongodb.org/browse/DOCSP-28363 w this ticket as well.
There was a problem hiding this comment.
90% sure https://jira.mongodb.org/browse/DOCSP-28363 doesn't require any work. waiting for final confirmation from the eng who opened that ticket. but merging this now.
Co-authored-by: Nick Larew <[email protected]>
Pull Request Info
Clean up auth examples
Jira
Staged Changes
Reminder Checklist
If your PR modifies the docs, you might need to also update some corresponding
pages. Check if completed or N/A.
Review Guidelines
REVIEWING.md