(DOCSP-12639): [realm-web] Update Google redirect deprecation note #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
reviewed
Oct 12, 2020
There was a problem hiding this comment.
@nlarew I'm sorry for being late to the party here, but I wanted to share some thoughts on this change.
Comment on lines
+540
to
+541
| then redirects to URL that you provide, which allows you to get an access | ||
| token and finish logging the user in. |
There was a problem hiding this comment.
Technically this is an "auth code" and not an access token and technically it's not the "user" that gets the code, but the SDK - since they don't need to handle it manually (other than calling Realm.handleAuthRedirect()).
| process faces limitations when authenticating :ref:`Google | ||
| <google-authentication>` users. If you use the Google login redirect flow | ||
| using Realm's redirect flow, a maximum of 100 Google users may authenticate | ||
| while the app is in development/testing/staging and all users will see an |
There was a problem hiding this comment.
"while the app is in development/testing/staging" => "while the app's consent screen isn't verified"
| <google-authentication>` users. If you use the Google login redirect flow | ||
| using Realm's redirect flow, a maximum of 100 Google users may authenticate | ||
| while the app is in development/testing/staging and all users will see an | ||
| unverified application notification before they authenticate. |
There was a problem hiding this comment.
Perhaps add "these are limitations imposed by Google".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
Issue JIRA link:
Docs staging link (requires sign-in on MongoDB Corp SSO):