Skip to content

(DOCSP-12450): JS Compatibility Table #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2020
Merged

(DOCSP-12450): JS Compatibility Table #527

merged 2 commits into from
Oct 9, 2020

Conversation

nlarew
Copy link
Collaborator

@nlarew nlarew commented Oct 7, 2020

Pull Request Info

Issue JIRA link:

Docs staging link (requires sign-in on MongoDB Corp SSO):

Copy link
Contributor

@ccho-mongodb ccho-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added some questions on a few items that weren't perfectly clear to me.

uncommon or unsuited to serverless workloads are not supported (e.g.
``WeakSet``, ``Proxy``, ``Array.prototype.flat()``).
uncommon or unsuited to serverless workloads are not supported. For more
information, see :ref:`JavaScript Feature Compatibility <js-feature-compat>`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: is there any advantage of using :ref: over the :doc: here? Seems like they both send you to the same place (top of the Javascript Feature Compatibility page).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No advantage other than we can change the page slug without needing to update this location. There's pros and cons to that but the rest of the realm team seems to prefer ref

@nlarew nlarew merged commit 66dbd9a into mongodb:master Oct 9, 2020
@nlarew nlarew deleted the es6 branch January 12, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants