This repository was archived by the owner on Mar 5, 2024. It is now read-only.
DOCSP-877 & DOCSP-879 - Parameterize filter and update saved pref. #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdestefano-mongo
commented
Nov 1, 2017
sphinxext/tabs.py
Outdated
| <ul class="tab-strip tab-strip--singleton" role="tablist"> | ||
| {{ for tab in tabs sortLanguages }} | ||
| <ul class="tab-strip tab-strip--singleton" role="tablist" PREFERENCE> | ||
| {{ for tab in tabs FILTER }} |
There was a problem hiding this comment.
Should we use some kind of notation with special characters or something to make it less like plain english? For example, $preference
There was a problem hiding this comment.
I would go with e.g. %PREFERENCE%, yeah
i80and
reviewed
Nov 1, 2017
| * @param {object} value The "tabId" and optional "type" (tab set) | ||
| */ | ||
| set tabPref(value) { | ||
| const tabPref = this.tabPref; |
There was a problem hiding this comment.
I'd not make this local variable
There was a problem hiding this comment.
Discussed offline, calling the getter method above.
| * @returns {object} Tab preference object. | ||
| */ | ||
| get tabPref() { | ||
| let pref = JSON.parse(window.localStorage.getItem(this.key)); |
There was a problem hiding this comment.
Consider making this just
return JSON.parse(window.localStorage.getItem(this.key)) || {};
jdestefano-mongo
force-pushed
the
master
branch
from
b80da59 to
33a1b10
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MUST BE MERGED WITH:
mongodb/docs#3074