Corrected double-negative #1019
Conversation
It looks to me like {$ne: t._id} specifies we can only perform this update if t._id is NOT already in the pendingTransactions array. The original description seemed to be saying the opposite (prevent not perform)!
|
I may have misunderstood, if "the transaction is not already pending" refers to the transactions collection, and not to the array inside the accounts documents. In which case, some clarification would be helpful. |
|
Thanks for the contribution! First of all, sorry for the delay in getting back to you on this. I'd like to get this merged in an published, but first we need you to sign the MongoDB Contributor Agreement. Once we have the signature on file we can move forward. Thanks so much for your effort, and sorry again for the delay! Cheers, |
|
Hi Joey -- As such, we will be closing your pull request. Thanks again for calling attention to this as well as your work. Regards, Kay Kim |
* DOCS-15267 * bump release in snooty.toml * bump snooty toml release
* (DOCSP-24027) MEKO support for OM 6.0 * Copy review * Reverted changes to upgrade mdb version as not needed for this PR * Now ready for a tech review * Adjust Kubernetes API version to 1.25 per review, ready to merge * Some more feedback based on a related ticket from support * (DOCSP-24802) changes to remove OM 4.4 altogether and fully, as per change of plans * A few edits, ready for a copy review, finally, again
* (DOCSP-24027) MEKO support for OM 6.0 * Copy review * Reverted changes to upgrade mdb version as not needed for this PR * Now ready for a tech review * Adjust Kubernetes API version to 1.25 per review, ready to merge * Some more feedback based on a related ticket from support * (DOCSP-24802) changes to remove OM 4.4 altogether and fully, as per change of plans * A few edits, ready for a copy review, finally, again
It looks to me like {$ne: t._id} specifies we can only perform this update if t._id is NOT already in the pendingTransactions array. The original description seemed to be saying the opposite (prevent if NOT, instead of perform if NOT)!