-
Notifications
You must be signed in to change notification settings - Fork 1.7k
DOCS-1824: Comment on: manual/reference/aggregation/operator-conditional... #1244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS-1824: Comment on: manual/reference/aggregation/operator-conditional... #1244
Conversation
@@ -1,8 +1,8 @@ | |||
name: :expression:`$cond` | |||
file: /reference/aggregation/cond | |||
description: Evaluates a an expression and returns a boolean. | |||
description: Evaluates one expression that returns a boolean. If ``true``, it returns the result of a second (perhaps non-boolean) expression. If ``false``, it returns the result of a third expression. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should wrap this using the multiline string formating in yaml.
also unclear what "it" is in the description.
also not sure that we need to have such a thorough definition in the table of content listing. perhaps it makes more sense to make the page itself have this definition (or a related definition, and then have this have a small to moderately sized definition that explains what's going on in this context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the pull request.
On Mon, Sep 9, 2013 at 3:12 PM, Sam Kleinman [email protected]:
In source/includes/ref-toc-aggregation-conditional.yaml:
@@ -1,8 +1,8 @@
name: :expression:$cond
file: /reference/aggregation/cond
-description: Evaluates a an expression and returns a boolean.
+description: Evaluates one expression that returns a boolean. Iftrue
, it returns the result of a second (perhaps non-boolean) expression. Iffalse
, it returns the result of a third expression.we should wrap this using the multiline string formating in yaml.
also unclear what "it" is in the description.
also not sure that we need to have such a thorough definition in the table
of content listing. perhaps it makes more sense to make the page itself
have this definition (or a related definition, and then have this have a
small to moderately sized definition that explains what's going on in this
context.—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1244/files#r6247643
.
Zack Brown
Technical Writer
MongoDB
Download MongoDB - mongodb.org/downloads
Free MongoDB Monitoring - mms.mongodb.com
Free Online Education - education.mongodb.com
Get Involved - mongodb.org/get-involved
I updated this pull request with a better description of ternary behavior. |
@@ -1,8 +1,8 @@ | |||
name: :expression:`$cond` | |||
file: /reference/aggregation/cond | |||
description: Evaluates a an expression and returns a boolean. | |||
description: A ternary operator that evaluates one expression, and depending on the result returns the value one of two expressions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is pretty vague, but judging by the $ifnull below it I guess they are supposed to be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are just quick descriptions to provide navigational assistance. The scope is fine, and consistent with other similar items throughout the docs.
merged! |
* Docs-15289 ldap connections (#1242) * DOCS-15289-LDAP-connections * DOCS-15289-LDAP-connections Co-authored-by: jason-price-mongodb <[email protected]> * Updated version numbers for LDAP parameters Co-authored-by: jason-price-mongodb <[email protected]>
* (DOCSP-27430): Fixed cert-manager setup issues. * (DOCSP-27430): Incorporated Nam's feedback. * (DOCSP-27430): Incorporated Will's feedback.
* parent e98a41e9df614305c8dcf74d03b727a80520c785 author Kanchana Sekhar <[email protected]> 1664200126 -0700 committer Kanchana Sekhar <[email protected]> 1681233229 -0700 DOCSP-25416 deploying OM/MDB in airgapped openshift environments tutorial Apply suggestions from code review Co-authored-by: John Williams <[email protected]> DOCSP-25416 updates for CR feedback DOCSP=25416 updates for feedback DOCSP-25416 another round of updates for feedback Apply suggestions from code review Co-authored-by: John Williams <[email protected]> DOCSP-25416 updates for JW feedback DOCSP-25416 updates for operator bundle size DOCSP-25416 latest round of revisions Update source/includes/steps-openshift-airgapped-env-tutorial.yaml Co-authored-by: dan-mckean <[email protected]> Update source/includes/steps-openshift-airgapped-env-tutorial.yaml Co-authored-by: John Williams <[email protected]> DOCSP-25416 updates for JW feedback DOCSP-25416 updates to add link DOCSP-28103 updates for changes suggested in the ticket DOCSP-28103 updates to the local mode installation step DOCSP-28103 updates for feedback Apply suggestions from code review Co-authored-by: John Williams <[email protected]> DOCSP-28103 updates for JW's feedback DOCSP=25416 updates for feedback DOCSP-25416 updates to add link (DOCSP-27047): Updated the resource image table with links to versions. (#1239) * (DOCSP-27047): Updated the resource image table with links to versions. * (DOCSP-27047): Incorporated JW's feedback. (DOCSP-25801) Fixed the steps for QS install TLS (#1246) * (DOCSP-25801) Fixed the steps for QS install TLS * Fix indentation * Fix indentation (DOCSP-26667)(DOCSP-26668): Clarify FCV behavior for DB resources & AppDB on OM resources (#1143) * (DOCSP-26667): AppDB will not change FCV automatically when upgrading version * (DOCSP-26668): Data Deployment will change FCV automatically when upgrading version * Fix link * Reword to avoid space in param name remove deprecated/unused files (#1250) (DOCSP-27430): Fixed cert-manager setup issues. (#1244) * (DOCSP-27430): Fixed cert-manager setup issues. * (DOCSP-27430): Incorporated Nam's feedback. * (DOCSP-27430): Incorporated Will's feedback. Fixed one ref and one bulleted list (#1254) DOCSP-28103 updates for LS's feedback DOCSP-28103 removed detailed steps for deploying OM in local mode * DOCSP-28103 redirects for prior versions * DOCSP-28103 updates for JW's feedback
* (DOCSP-27430): Fixed cert-manager setup issues. * (DOCSP-27430): Incorporated Nam's feedback. * (DOCSP-27430): Incorporated Will's feedback.
* parent e98a41e9df614305c8dcf74d03b727a80520c785 author Kanchana Sekhar <[email protected]> 1664200126 -0700 committer Kanchana Sekhar <[email protected]> 1681233229 -0700 DOCSP-25416 deploying OM/MDB in airgapped openshift environments tutorial Apply suggestions from code review Co-authored-by: John Williams <[email protected]> DOCSP-25416 updates for CR feedback DOCSP=25416 updates for feedback DOCSP-25416 another round of updates for feedback Apply suggestions from code review Co-authored-by: John Williams <[email protected]> DOCSP-25416 updates for JW feedback DOCSP-25416 updates for operator bundle size DOCSP-25416 latest round of revisions Update source/includes/steps-openshift-airgapped-env-tutorial.yaml Co-authored-by: dan-mckean <[email protected]> Update source/includes/steps-openshift-airgapped-env-tutorial.yaml Co-authored-by: John Williams <[email protected]> DOCSP-25416 updates for JW feedback DOCSP-25416 updates to add link DOCSP-28103 updates for changes suggested in the ticket DOCSP-28103 updates to the local mode installation step DOCSP-28103 updates for feedback Apply suggestions from code review Co-authored-by: John Williams <[email protected]> DOCSP-28103 updates for JW's feedback DOCSP=25416 updates for feedback DOCSP-25416 updates to add link (DOCSP-27047): Updated the resource image table with links to versions. (#1239) * (DOCSP-27047): Updated the resource image table with links to versions. * (DOCSP-27047): Incorporated JW's feedback. (DOCSP-25801) Fixed the steps for QS install TLS (#1246) * (DOCSP-25801) Fixed the steps for QS install TLS * Fix indentation * Fix indentation (DOCSP-26667)(DOCSP-26668): Clarify FCV behavior for DB resources & AppDB on OM resources (#1143) * (DOCSP-26667): AppDB will not change FCV automatically when upgrading version * (DOCSP-26668): Data Deployment will change FCV automatically when upgrading version * Fix link * Reword to avoid space in param name remove deprecated/unused files (#1250) (DOCSP-27430): Fixed cert-manager setup issues. (#1244) * (DOCSP-27430): Fixed cert-manager setup issues. * (DOCSP-27430): Incorporated Nam's feedback. * (DOCSP-27430): Incorporated Will's feedback. Fixed one ref and one bulleted list (#1254) DOCSP-28103 updates for LS's feedback DOCSP-28103 removed detailed steps for deploying OM in local mode * DOCSP-28103 redirects for prior versions * DOCSP-28103 updates for JW's feedback
....txt