edit to syntax example #1421
Closed
edit to syntax example #1421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,7 +27,7 @@ schema: | |||
| db: "<database>", | |||
| privileges: [ | |||
| { | |||
| resource: <resource document>, | |||
| resource: { <resource> }, | |||
There was a problem hiding this comment.
I think the previous one is better given these two options, but along the lines of your edit, how about if we do something like:
{
// ...
resources: { "db": <name> <, collection: <name>> }
// ...
}
or something that prototypes a resource document a little bit more clearly.
There was a problem hiding this comment.
I think the answer is your proposal. I was torn about the "//" -- if we use the commenting out, then we have a dangling comma (see second patch) -- so I left it as is, without the //. This isn't something the user should cut and paste, as our examples are, so I think we're ok not to put in comment slashed.
|
merged. put resource document to since it has 2 forms |
mongo-cr-bot
pushed a commit
that referenced
this pull request
Jul 15, 2022
mongodb-server-docs-sync-bot bot
pushed a commit
that referenced
this pull request
Jun 26, 2025
* (DOCSP-31095) Adds MongoDBUser CRD example and spec reference. * Revises per tech and copy review.
mongodb-server-docs-sync-bot bot
pushed a commit
that referenced
this pull request
Jun 26, 2025
* (DOCSP-31095) Adds MongoDBUser CRD example and spec reference. * Revises per tech and copy review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would merge this, but another set of eyes should approve it.